Author: rgoers
Date: Sun May 30 07:42:38 2010
New Revision: 949488
URL: http://svn.apache.org/viewvc?rev=949488&view=rev
Log:
Comment on @doubt entries
Modified:
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java
Modified:
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java
URL:
http://svn.apache.org/viewvc/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java?rev=949488&r1=949487&r2=949488&view=diff
==============================================================================
---
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java
(original)
+++
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java
Sun May 30 07:42:38 2010
@@ -33,7 +33,7 @@ import java.util.Map;
* child thread automatically inherits a <em>copy</em> of the mapped
* diagnostic context of its parent.
*
- * @doubt I'd throw the concept into a ThreadContext object.
+ * @doubt I'd throw the concept into a ThreadContext object. (RG) I agree -
will revise this.
*/
public final class MDC {
Modified:
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java
URL:
http://svn.apache.org/viewvc/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java?rev=949488&r1=949487&r2=949488&view=diff
==============================================================================
---
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java
(original)
+++
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java
Sun May 30 07:42:38 2010
@@ -83,7 +83,10 @@ import java.util.concurrent.ConcurrentMa
* method. A thread may obtain a copy of its NDC with the {...@link
* #cloneStack cloneStack} method and pass the reference to any other
* thread, in particular to a child.
- * @doubt I'd combine MDC and NDC into a single ThreadContext object.
+ * @doubt I'd combine MDC and NDC into a single ThreadContext object. (RG) To
be
+ * honest, I've always doubted the practicality of this class. An errant
+ * app that forgets to pop an element will screw it up. I only added it
+ * because Log4J 1.x supports it and it wasn't particularly hard to carry over.
*/
public class NDC {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
