Author: rgoers
Date: Sun May 30 08:04:14 2010
New Revision: 949490
URL: http://svn.apache.org/viewvc?rev=949490&view=rev
Log:
Comment on @doubt entries
Modified:
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core/Logger.java
Modified:
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core/Logger.java
URL:
http://svn.apache.org/viewvc/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core/Logger.java?rev=949490&r1=949489&r2=949490&view=diff
==============================================================================
---
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core/Logger.java
(original)
+++
logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core/Logger.java
Sun May 30 08:04:14 2010
@@ -28,7 +28,7 @@ import java.util.List;
import java.util.Map;
/**
- * @doubt All the isEnabled methods could be pushed into a filter interface.
Not sure of the utility of having isEnabled
+ * @doubt All the isEnabled methods could be pushed into a filter interface.
Not sure of the utility of having isEnabled
* be able to examine the message pattern and parameters.
*/
public class Logger extends AbstractLogger {
@@ -165,7 +165,7 @@ public class Logger extends AbstractLogg
* volatile.
*
* @param config The new Configuration.
- * @doubt lost me on the comment, this.config is declared volatile.
+ * @doubt lost me on the comment, this.config is declared volatile. (RG)
Me too.
*/
void updateConfiguration(Configuration config) {
this.config = new PrivateConfig(config, this);
@@ -175,7 +175,7 @@ public class Logger extends AbstractLogg
* @doubt class is not immutable, so it should not be shared between
threads.
*/
protected class PrivateConfig {
- /** @doubt public member variables? **/
+ /** @doubt public member variables? (RG) Should be changed. Did this
while making the Log4j 1.2 API **/
public final LoggerConfig loggerConfig;
public final Configuration config;
public Level level;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
