https://issues.apache.org/bugzilla/show_bug.cgi?id=43282

John Gibson <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #8 from John Gibson <[email protected]> 2010-07-12 12:16:35 EDT 
---
Sorry for not responding earlier, but I forgot to add myself to the CC list.

Anyway, I agree with Craig, we need a version number on all of the exported
packages.  It will keep behavior predictable if a user accidentally (or, on
purpose for some strange reason) loads multiple version of Log4J into an OSGi
environment at once.

Another enhancement that you might consider is packaging the NT appender DLLs
inside the bundle.  With headers like this:

Bundle-NativeCode: NTEventLogAppender.dll;osname=Win32;processor=x86,
 NTEventLogAppender.amd64.dll;osname=Win32;processor=x86-64,
 *

OSGi is smart enough to unpack the necessary DLL from the bundle and load it on
demand.

If 55K is too much bloat for the Log4J jar, then they could be packaged
separately and added as a fragment bundle.

WRT Log4J extras, again adding the version number for the exported packages is
important.  In addition, you can handle the split packages problem gracefully
if you make it a fragment bundle.  A fragment bundle will not function by
itself in OSGi, but instead requires the log4j bundle to be loaded first.  Then
the contents of the fragment bundle become accessible to the classloader
provided by host bundle.  To do this you just add a header like so:

Fragment-Host: log4j;bundle-version="1.2.9"

This would instruct the log4j extras bundle to attach itself to the log4j
bundle if the version number of the parent bundle is greater than or equal to
1.2.9.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to