On 17.09.2011, at 21:34, Ralph Goers wrote:
>
> On Sep 17, 2011, at 12:26 PM, Joern Huxhorn wrote:
>
>>
>> The code simply looks like this:
>> public void log(Level level, String messagePattern, Object... args) {
>> if (!isEnabled(level)) return;
>> ParameterizedMessage message =
>> ParameterizedMessage.create(messagePattern, args);
>> performLogging(level, null, message, message.getThrowable());
>> }
>
> Thanks. This is the source of the bug. The API is currently not doing
> message.getThrowable(). I'll fix that shortly.
>
> But I also do like John's suggestion that ParameterizedMessage and
> StructuredDataMessage could be interfaces. What are your thoughts on that?
May make sense.
I'm not sure, yet, where this would be of actual use but I wouldn't rule it out
because of that.
One thing that makes me keeps poking me concerning this suggestion is the fact
that the RFC5424 StructuredDataMessage has specific requirements concerning the
key-length while other implementations likely wouldn't. This means that those
implementations couldn't simply be exchanged since RFC5424 would throw an, say,
IllegalArgumentException for a key longer than 32 chars while others wouldn't.
Joern.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
