Hi All:
I see:
/**
* Enhances a Class by allowing it to contain Filters.
*/
public class Filterable implements Filtering {
Which looks really weird to my eye, especially when I read:
public abstract class AbstractAppender extends Filterable implements
Appender, Lifecycle {
A type that is -able, is usually an interface, not a class, for example:
Comparable, Iterable, Serializable. (Yes, the obvious exception is
Throwable, pun intended).
My malaise is compounded by the name of the interface "Filtering" which is
described as "Enhances a Class by allowing it to contain Filters.". A -ing
class name is just
I propose to rename:
- Filtering (the interface) to:
Filterable or
FilterCollection
- Filterable (the class) to:
FilterObject or
FilterContainer or
FilterHolder or
FilterWrapper
such that, for example FilterObject implements Filterable
Thoughts?
Gary
--
E-Mail: [email protected] | [email protected]
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
