Hmm. The tests can certainly be cleaned up. I'm surprised at some of the other ones but they may be the result of refactoring. Give me a day or two to look at them.
On Jan 10, 2013, at 10:33 PM, Gary Gregory wrote: > Should these unused fields be removed? > > Description Resource Path Location Type > The value of the field XMLConfiguration.Status.element is not used > XMLConfiguration.java > /log4j-core/src/main/java/org/apache/logging/log4j/core/config line 324 > Java Problem > The value of the field FlumeEmbeddedManager.conf is not used > FlumeEmbeddedManager.java > /log4j-flume-ng/src/main/java/org/apache/logging/log4j/flume/appender line > 41 Java Problem > The value of the field LogManager.LOGGER_RESOURCE is not used > LogManager.java /log4j-api/src/main/java/org/apache/logging/log4j line > 44 Java Problem > The value of the field FlumeEmbeddedManager.shortName is not used > FlumeEmbeddedManager.java > /log4j-flume-ng/src/main/java/org/apache/logging/log4j/flume/appender line > 49 Java Problem > The value of the field LogManager.LOGGER_CONTEXT_FACTORY is not used > LogManager.java /log4j-api/src/main/java/org/apache/logging/log4j line > 45 Java Problem > The value of the field LogManager.API_VERSION is not used LogManager.java > /log4j-api/src/main/java/org/apache/logging/log4j line 46 Java Problem > The value of the field LogManager.FACTORY_PRIORITY is not used > LogManager.java /log4j-api/src/main/java/org/apache/logging/log4j line > 47 Java Problem > The value of the field LoggerTest.root is not used LoggerTest.java > /log4j-to-slf4j/src/test/java/org/apache/logging/slf4j line 52 Java > Problem > The value of the field Logger.FQCN is not used Logger.java > /log4j-12-api/src/main/java/org/apache/log4j line 28 Java Problem > The value of the field SocketAppenderTest.HOST is not used > SocketAppenderTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/appender line 52 > Java Problem > The value of the field SimplePerfTest.lvl is not used SimplePerfTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core line 35 Java > Problem > The value of the field JMSQueueFailoverTest.receiver is not used > JMSQueueFailoverTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/net line 56 > Java Problem > The value of the field XMLConfigurationPropsTest.LOGFILE is not used > XMLConfigurationPropsTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/config line 34 > Java Problem > The value of the field FormattedMessage.LOGGER is not used > FormattedMessage.java > /log4j-api/src/main/java/org/apache/logging/log4j/message line 37 Java > Problem > The value of the field SyslogAppender.BSD is not used SyslogAppender.java > /log4j-core/src/main/java/org/apache/logging/log4j/core/appender line 40 > Java Problem > The value of the field BasicThreadInformation.longName is not used > BasicThreadInformation.java > /log4j-api/src/main/java/org/apache/logging/log4j/message line 27 Java > Problem > The value of the field BasicThreadInformation.isAlive is not used > BasicThreadInformation.java > /log4j-api/src/main/java/org/apache/logging/log4j/message line 30 Java > Problem > The value of the field JMSTopicTest.receiver is not used JMSTopicTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/net line 61 > Java Problem > The value of the field SyslogAppenderTest.HOST is not used > SyslogAppenderTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/appender line 52 > Java Problem > The value of the field JMSQueueAppenderTest.receiver is not used > JMSQueueAppenderTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/net line 52 > Java Problem > The value of the field ThreadContextMapFilter.value is not used > ThreadContextMapFilter.java > /log4j-core/src/main/java/org/apache/logging/log4j/core/filter line 44 > Java Problem > The value of the field ThreadedPerfTest.lvl is not used > ThreadedPerfTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core line 32 Java > Problem > The value of the field FlumeAppenderTest.ctx is not used > FlumeAppenderTest.java > /log4j-flume-ng/src/test/java/org/apache/logging/log4j/flume/appender line > 64 Java Problem > The value of the field Log4jContextListenerTest.MockServletContext.name is > not used Log4jContextListenerTest.java > /log4j-web/src/test/java/org/apache/logging/log4j/core/web line 121 > Java Problem > The value of the field PatternParserTest.mdcMsgPattern2 is not used > PatternParserTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/pattern line 52 > Java Problem > The value of the field PatternParserTest.mdcMsgPattern1 is not used > PatternParserTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/pattern line 51 > Java Problem > The value of the field PatternParserTest.mdcMsgPattern4 is not used > PatternParserTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/pattern line 54 > Java Problem > The value of the field JSONConfigurationFactory.configFile is not used > JSONConfigurationFactory.java > /log4j-core/src/main/java/org/apache/logging/log4j/core/config line 39 > Java Problem > The value of the field PatternParserTest.mdcMsgPattern3 is not used > PatternParserTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/pattern line 53 > Java Problem > The value of the field RFC5424Layout.DEFAULT_CONVERSION_PATTERN is not used > RFC5424Layout.java > /log4j-core/src/main/java/org/apache/logging/log4j/core/layout line 94 > Java Problem > The value of the field SerializedLayoutTest.body is not used > SerializedLayoutTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/layout line 61 > Java Problem > The value of the field PatternParserTest.mdcMsgPattern5 is not used > PatternParserTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/pattern line 55 > Java Problem > The value of the field SimpleLoggerContext.simpleLogProps is not used > SimpleLoggerContext.java > /log4j-api/src/main/java/org/apache/logging/log4j/simple line 45 Java > Problem > The value of the field ThreadedTest.lvl is not used ThreadedTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core line 40 Java > Problem > The value of the field FilterPerformanceComparison.THREADED_COUNT is not used > FilterPerformanceComparison.java > /log4j-core/src/test/java/org/apache/logging/log4j line 35 Java Problem > The value of the field SimplePerfTest.rand is not used SimplePerfTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core line 39 Java > Problem > The value of the field SimplePerfTest.values is not used > SimplePerfTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core line 41 Java > Problem > The value of the field JMSQueueTest.receiver is not used JMSQueueTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/net line 61 > Java Problem > The value of the field SocketServerTest.HOST is not used > SocketServerTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/net line 49 > Java Problem > The value of the field HTMLLayout.contentType is not used HTMLLayout.java > /log4j-core/src/main/java/org/apache/logging/log4j/core/layout line 63 > Java Problem > The value of the field SocketServerTest.list is not used > SocketServerTest.java > /log4j-core/src/test/java/org/apache/logging/log4j/core/net line 53 > Java Problem > The value of the field JSONConfiguration.Status.node is not used > JSONConfiguration.java > /log4j-core/src/main/java/org/apache/logging/log4j/core/config line 296 > Java Problem > > > Gary > > -- > E-Mail: [email protected] | [email protected] > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 > Spring Batch in Action: http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
