[
https://issues.apache.org/jira/browse/LOG4J2-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552812#comment-13552812
]
Gary Gregory edited comment on LOG4J2-149 at 1/14/13 3:52 PM:
--------------------------------------------------------------
The question is likely for Ralph.
It seems wrong that SMTPAppender.isFiltered(LogEvent) adds the log event to the
cyclic buffer.
Perhaps a touch of comments would help ;)
Gary
was (Author: garydgregory):
The question is likely for Ralph.
It seems wrong that SMTPAppender.isFiltered(LogEvent) add the log event to the
cyclic buffer.
Perhaps a touch of comments would help ;)
Gary
> SMTPManager buffer access not synchronized; can result in empty emails
> ----------------------------------------------------------------------
>
> Key: LOG4J2-149
> URL: https://issues.apache.org/jira/browse/LOG4J2-149
> Project: Log4j 2
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 2.0-beta4
> Environment: N/A
> Reporter: Scott Severtson
> Attachments: SMTPManager-buffer-synchronization.patch
>
>
> If multiple error events are logged against the same SMTPAppender/Manager at
> the same time, one email will contain both error messages, while the second
> will be empty (no events).
> The original SMTPAppender patch included synchronization against the
> CyclicBuffer to prevent such simultaneous access from multiple threads. This
> appears to have been lost in the merge/refactor. Patch (to follow shortly)
> re-introduces synchronization against the CyclicBuffer in the narrowest
> possible scope.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
