Ah ok. Thanks! I think I've done all that then. I just wasn't sure if there was another JIRA status that I can move it to, as in "Pending Review" instead of just "Open" or if I should assign it to someone specifically.
From: ralph.go...@dslextreme.com Subject: Re: Code review request Date: Wed, 27 Feb 2013 15:53:09 -0800 To: log4j-dev@logging.apache.org Also, beware that it may take a bit before I get a chance to review it. I have been absolutely swamped with my $DayJob since the beginning of the year. Ralph On Feb 27, 2013, at 3:51 PM, Ralph Goers wrote:We have not implemented a code review tool. Just go ahead and submit it as a patch (or zip) that can be applied to trunk to the Jira issue along with a comment requesting that it be reviewed. FWIW, committers on logging normally follow the commit-then-review model and we get emails with the diffs that we look at. However, I followed the same process I am recommending to you for both LOG4J2-154 and LOG4J2-161 because both are critical parts of the code that I felt could use more eyeballs on them before they are integrated in. Ralph On Feb 27, 2013, at 3:30 PM, Joanne Polsky wrote:Hi, I was wondering what the process is to request a code review for a new feature - https://issues.apache.org/jira/browse/LOG4J2-160 Thanks, Joanne
