[ 
https://issues.apache.org/jira/browse/LOG4J2-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Remko Popma updated LOG4J2-193:
-------------------------------

    Attachment: LOG4J2-193-with-doc-updates.patch
                documentation-update-images-20130402.zip

Please find attached LOG4J2-193-with-doc-updates.patch.

This patch makes the proposed change to RollingFileManager and fixes 
FastRollingFileManager.

This patch also resolves a performance issue that was still there with 
FastRollingFileManager. I've re-run the relevant performance tests and updated 
the async manual page.

This patch also contains documentation changes to the async manual page and the 
overall performance page I proposed yesterday in LOG4J2-163. (I will remove 
those files from LOG4J2-163 and close it.)
Please unzip attached file documentation-update-images-20130402.zip into the 
src/site/resources/images/ directory.
                
> RollingFastFileAppender (in log4j-async) does not roll over
> -----------------------------------------------------------
>
>                 Key: LOG4J2-193
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-193
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>            Reporter: Remko Popma
>         Attachments: documentation-update-images-20130402.zip, 
> LOG4J2-193-with-doc-updates.patch
>
>
> The FastRollingFileManager used by RollingFastFileAppender extends the core 
> RollingFileManager.
> I made a mistake in my implementation of FastRollingFileManager and it does 
> not correctly create a new RandomFile during rollover.
> To fix the issue I need a small change to 
> core.appender.rolling.RollingFileManager#checkRollover(LogEvent):
> inside this method there are two lines where the new FileOutputStream is 
> created and passed to the parent OutputStreamAppender.
> If these two lines can be extracted into a protected method, subclasses like 
> FastRollingFileManager can override and implement their own behaviour.
> Patch to follow soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to