[ 
https://issues.apache.org/jira/browse/LOG4J2-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625053#comment-13625053
 ] 

Nick Williams commented on LOG4J2-187:
--------------------------------------

- I don't know why `svn diff` did that. I copied these three files from the web 
subproject as a starting point. `svn diff` set them up as diffs "copied from" 
the web subproject instead of files "added." Sorry about this. I don't know how 
to make SVN not do this.

- I did not know about the @author tags. My apologies. Feel free to remove them 
or, if necessary, I can remove them and re-submit the patch. Whichever is 
easier/quicker.

- All of the unit tests for the rest of the project (API, core, web, etc.) 
pass. I am working on unit tests for the taglib subproject, but wanted to get 
this submitted so that people could start hammering on it, in case I didn't 
finish unit tests before beta5 was released.
                
> Log4j 2 Taglib
> --------------
>
>                 Key: LOG4J2-187
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-187
>             Project: Log4j 2
>          Issue Type: New Feature
>    Affects Versions: 2.0-beta5
>            Reporter: Nick Williams
>              Labels: log4j, patch, taglib
>             Fix For: 2.0-beta5
>
>         Attachments: Added_Log4j_Tab_Library.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> As discussed on the log4j-dev mailing list, I have created a new component 
> for Log4j 2: log4j-taglib.
> More details on discussion is here: 
> http://markmail.org/thread/gbwjsthvu7qsh5zo
> Will attach patch in comment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to