[
https://issues.apache.org/jira/browse/LOG4J2-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649090#comment-13649090
]
Nick Williams commented on LOG4J2-237:
--------------------------------------
Remko, since it's necessary to have BOTH the jmx-gui AND core JARs on the
classpath to run JConsole, would it make sense for the jmx-gui JAR to be an
assembly containing the jmx-gui classes AND the classes from the core JAR? This
is usually more desirable for applications where you have to specify this from
the command line.
Also, the /META-INF/services/com.sun.tools.jconsole.JConsolePlugin service
provider file should probably have the Apache License header at the top of it.
You can see an example of how to do that properly here:
https://github.com/FasterXML/jackson-datatype-jsr310/blob/master/src/main/resources/META-INF/services/com.fasterxml.jackson.databind.Module.
Java allows comments in this way in service provider files.
> Move JMX GUI classes out of the core module into a new submodule
> ----------------------------------------------------------------
>
> Key: LOG4J2-237
> URL: https://issues.apache.org/jira/browse/LOG4J2-237
> Project: Log4j 2
> Issue Type: Dependency upgrade
> Components: Core
> Affects Versions: 2.0-beta5
> Reporter: Remko Popma
> Assignee: Remko Popma
> Priority: Minor
> Fix For: 2.0-beta6
>
>
> See discussion in LOG4J2-235.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
