Yes. We were on 2.3.2 and the jvmArgs element wasn't supported in that release.

Ralph

On May 4, 2013, at 11:33 PM, Remko Popma wrote:

> Hey it looks like that worked! I tried that earlier but it did not work 
> before. Maybe the findbugs version upgrade helped?
> Anyway, nice!
> 
> From: Ralph Goers <[email protected]>
> To: Log4J Developers List <[email protected]>; Remko Popma 
> <[email protected]> 
> Sent: Sunday, May 5, 2013 3:12 PM
> Subject: Re: Trivialities
> 
> Can you update and try it again?  I added 
> <jvmArgs>-Duser.language=en</jvmArgs>  in the hopes that it will resolve the 
> problem you are having.
> 
> Ralph
> 
> On May 4, 2013, at 11:07 PM, Remko Popma wrote:
> 
>> No problem. Maybe we can think of something that works for both of us later.
>> 
>> Remko
>> 
>> From: Ralph Goers <[email protected]>
>> To: Log4J Developers List <[email protected]>; Remko Popma 
>> <[email protected]> 
>> Sent: Sunday, May 5, 2013 2:42 PM
>> Subject: Re: Trivialities
>> 
>> I'm afraid I am going to have to change this back.  The maven site build now 
>> fails for me with an out of memory error.  Changing it back to true solves 
>> the problem.
>> 
>> Ralph
>> 
>> On May 1, 2013, at 8:18 AM, Remko Popma wrote:
>> 
>>> I went ahead and committed the change to add <fork>false</fork> to the 
>>> findbugs-maven-plugin configuration in api/pom.xml
>>> 
>>> (revision 1478046)
>>> 
>>> From: Remko Popma <[email protected]>
>>> To: Log4J Developers List <[email protected]> 
>>> Sent: Monday, April 29, 2013 12:16 PM
>>> Subject: Re: Trivialities
>>> 
>>> I went ahead and committed changes to checkstyle.xml to remove false 
>>> positives for NewlineAtEndOfFile and whitespace at end of line.
>>> (revision 1476883)
>>> The CheckStyle error count went down from 429 to 175.
>>> 
>>> 
>>> Any objections on (2) below: adding <fork>false</fork> to the 
>>> findbugs-maven-plugin configuration in api/pom.xml?
>>> (not committed yet)
>>> 
>>> 
>>> From: Remko Popma <[email protected]>
>>> To: Log4J Dev-List <[email protected]> 
>>> Sent: Sunday, April 28, 2013 10:02 PM
>>> Subject: Trivialities
>>> 
>>> Trivialities
>>> 
>>> 1) (note)
>>> In o.a.l.l.c.c.p.ResolverUtil line 279 
>>> I put the cast back in this line removing the cast broke the build on my 
>>> machine:
>>> 
>>> //Do not remove the cast on the next line as removing it will cause a 
>>> compile error on Java 7.
>>> final BundleWiring wiring = (BundleWiring) FrameworkUtil.getBundle(
>>>                 ResolverUtil.class).adapt(BundleWiring.class);
>>> 
>>> 
>>> 2) (request)
>>> On my Japanese Windows 7, I have trouble building the site (mvn site).
>>> This seems to be caused by findbugs-maven-plugin encountering encoding 
>>> issues.
>>> The problem goes away if I modify api/pom.xml to add <fork>false</fork> to 
>>> the findbugs configuration. I am guessing the <locales>en</locales> tag
>>> in the global pom.xml is not passed on if the process is forked.
>>> 
>>> Does anyone mind if I commit this change (adding <fork>false</fork>
>>> to the findbugs-maven-plugin configuration in api/pom.xml)?
>>> 
>>> 
>>> 3) (request)
>>> checkstyle.xml has a check "RegexpSingleline" that checks if a line has 
>>> trailing spaces.
>>> This is a bit embarrassing, but I cannot figure out how to modify the
>>> autoformatter on my IDE (Eclipse) so that it does not add spaces in javadoc
>>> comments like this:
>>> /**
>>>  * Some comment line
>>>  *                    <-- Eclipse auto-format adds a single space after the 
>>> '*'
>>>  * @param someParam param explanation
>>>  */
>>> 
>>> Checkstyle flags all these comments as problems.
>>> Can we consider these to be false positives and add an exception to this 
>>> rule
>>> so that a space after a '*' character is not flagged as a trailing space?
>>> (I still need to figure out the regular expression for this.)
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>> 
>> 
>> 
> 
> 
> 

Reply via email to