I believe everything below has been resolved. Are there other issues to cover before I respin?
Ralph On May 6, 2013, at 9:40 AM, Gary Gregory wrote: > Hi All: > > -1, see below WRT missing license headers. > > - I just fixed the FindBugs issue from > https://people.apache.org/~rgoers/log4j2/log4j-api/findbugs.html > Bug Category Details Line Priority > Argument of type String can't be handled by format specifier %d in new > org.apache.logging.log4j.message.StructuredDataId(String, String[], String[]) > CORRECTNESS VA_FORMAT_STRING_BAD_CONVERSION 60 High > > Not a showstopper though... just not pretty. > > - But, we have some license header problems here: > https://people.apache.org/~rgoers/log4j2/log4j-core/rat-report.html > > That is a showstopper, so -1 and I've fixed this in SVN. > > - This needs attention: > org.apache.logging.log4j.core.pattern.LevelPatternConverter > > Bug Category Details Line Priority > Null passed for nonnull parameter of java.util.EnumMap.put(Enum, Object) in > org.apache.logging.log4j.core.pattern.LevelPatternConverter.newInstance(String[]) > CORRECTNESS NP_NULL_PARAM_DEREF 69 High > > Probably by changing: > > if (level == null) { > LOGGER.error("Invalid Level {}", pair[0].trim()); > } > levelMap.put(level, pair[1].trim()); > > to: > > if (level == null) { > LOGGER.error("Invalid Level {}", pair[0].trim()); > } else { > levelMap.put(level, pair[1].trim()); > } > > But I'll Iet RG decide on the best fix. > > - https://people.apache.org/~rgoers/log4j2/log4j-flume-ng/index.html > > The example refer to beta1 (<log4j.version>2.0-beta1</log4j.version>) instead > of beta6. > > Gary > > > > > > On Sun, May 5, 2013 at 10:44 PM, Ralph Goers <[email protected]> > wrote: > This is a vote to release Log4j 2.0-beta6, the eighth release of Log4j 2.0. > > Changes in this version include: > > Fixed Bugs: > o LOG4J2-231: Logger.getParent() was not returning the correct Logger. > o LOG4J2-201: Renamed Plugin annotation attribute from "type" to "category". > o LOG4J2-219: Fix: install default root logger if not configured (this is > unchanged), > but make sure to include configured named loggers. Clarified > documentation. Thanks to Peter DePasquale. > o LOG4J2-159: Use OSGi version format in Fragment-Host > o LOG4J2-234: RegexFilter threw a NullPointerException when used as a > context-wide filter. > o LOG4J2-192: Add support for interpolating Environment variables when > processing the configuration. > o LOG4J2-235: Removed dependency on tools jar from core module, made > jconsole dependency optional. Thanks to Sebastian Oerding. > o LOG4J2-233: Fixed link to log4j-user mailing list. > o LOG4J2-222: Disruptor will now shutdown during Tomcat shutdown. Thanks to > Steven Yang. > o LOG4J2-224: The FlumeAppender failed to start if the Flume RPCClient could > not connect to any Flume agents. > o LOG4J2-223: Fix LoggerContext start and stop to eliminate > IllegalStateException and NoClassDefFound errors. > o LOG4J2-221: Remove hundreds of compiler warnings. Thanks to Nick Williams. > o LOG4J2-215: Various small documentation fixes. > o LOG4J2-217: Ensure PluginManager streams are always closed. Thanks to > Fabien Sanglard. > > Changes: > o LOG4J2-237: Moved JMX Client GUI classes into separate jmx-gui submodule. > o LOG4J2-230: Improved error reporting when misconfigured. Thanks to > Wojciech Zaręba. > o Renamed AsynchAppender to AsyncAppender. Plugin name became Async (was > Asynch). > o Removed CheckStyle false positives for NewlineAtEndOfFile and whitespace > following '*' at end of line in javadoc. > o Moved Clock interface to package org.apache.logging.log4j.core.helpers. > o LOG4J2-225: Documentation updates to clarify use and impact of location in > pattern layouts. > > Please test and cast your votes. > [] +1, release the artifacts > [] -1, don't release because… > > The vote will remain open for 72 hours (or more if required). > > Tag: > https://svn.apache.org/repos/asf/logging/log4j/log4j2/tags/log4j-2.0-beta6/ > > Web Site: http://people.apache.org/~rgoers/log4j2/ > > Artifacts: > https://repository.apache.org/content/repositories/orgapachelogging-004/ > > The artifacts may be downloaded using > wget -e robots=off --cut-dirs=3 -r -p -np --no-check-certificate > https://repository.apache.org/content/repositories/orgapachelogging-004/org/apache/logging/log4j/ > > Description: > > 2.0-beta6 rc1 > > Details: > > The following artifacts have been staged to the org.apache.logging-004 > (u:rgoers, a:99.180.69.21) repository. > > archetype-catalog.xml > log4j-jmx-gui-2.0-beta6.jar.asc > log4j-jmx-gui-2.0-beta6-sources.jar > log4j-jmx-gui-2.0-beta6-javadoc.jar > log4j-jmx-gui-2.0-beta6-sources.jar.asc > log4j-jmx-gui-2.0-beta6.pom > log4j-jmx-gui-2.0-beta6-javadoc.jar.asc > log4j-jmx-gui-2.0-beta6.jar > log4j-jmx-gui-2.0-beta6.pom.asc > log4j-web-2.0-beta6.jar.asc > log4j-web-2.0-beta6-sources.jar > log4j-web-2.0-beta6.jar > log4j-web-2.0-beta6-sources.jar.asc > log4j-web-2.0-beta6-javadoc.jar.asc > log4j-web-2.0-beta6.pom.asc > log4j-web-2.0-beta6-javadoc.jar > log4j-web-2.0-beta6.pom > log4j-slf4j-impl-2.0-beta6.pom.asc > log4j-slf4j-impl-2.0-beta6-javadoc.jar.asc > log4j-slf4j-impl-2.0-beta6.pom > log4j-slf4j-impl-2.0-beta6-javadoc.jar > log4j-slf4j-impl-2.0-beta6.jar > log4j-slf4j-impl-2.0-beta6.jar.asc > log4j-slf4j-impl-2.0-beta6-sources.jar > log4j-slf4j-impl-2.0-beta6-sources.jar.asc > flume-remote-2.0-beta6.pom.asc > flume-remote-2.0-beta6.pom > flume-remote-2.0-beta6.war > flume-remote-2.0-beta6.war.asc > flume-remote-2.0-beta6-sources.jar.asc > flume-remote-2.0-beta6-sources.jar > flume-common-2.0-beta6.pom > flume-common-2.0-beta6-sources.jar > flume-common-2.0-beta6.jar > flume-common-2.0-beta6-javadoc.jar.asc > flume-common-2.0-beta6.jar.asc > flume-common-2.0-beta6-sources.jar.asc > flume-common-2.0-beta6.pom.asc > flume-common-2.0-beta6-javadoc.jar > flume-embedded-2.0-beta6.war > flume-embedded-2.0-beta6.pom.asc > flume-embedded-2.0-beta6-sources.jar.asc > flume-embedded-2.0-beta6.pom > flume-embedded-2.0-beta6.war.asc > flume-embedded-2.0-beta6-sources.jar > log4j-samples-2.0-beta6.pom > log4j-samples-2.0-beta6.pom.asc > log4j-jcl-2.0-beta6-javadoc.jar.asc > log4j-jcl-2.0-beta6-sources.jar > log4j-jcl-2.0-beta6.jar > log4j-jcl-2.0-beta6.jar.asc > log4j-jcl-2.0-beta6.pom.asc > log4j-jcl-2.0-beta6.pom > log4j-jcl-2.0-beta6-javadoc.jar > log4j-jcl-2.0-beta6-sources.jar.asc > log4j-taglib-2.0-beta6-javadoc.jar > log4j-taglib-2.0-beta6.jar > log4j-taglib-2.0-beta6-sources.jar.asc > log4j-taglib-2.0-beta6.jar.asc > log4j-taglib-2.0-beta6.pom > log4j-taglib-2.0-beta6.pom.asc > log4j-taglib-2.0-beta6-javadoc.jar.asc > log4j-taglib-2.0-beta6-sources.jar > log4j-distribution-2.0-beta6-src.tar.gz.asc > log4j-distribution-2.0-beta6-bin.tar.gz > log4j-distribution-2.0-beta6-src.tar.gz > log4j-distribution-2.0-beta6-bin.tar.gz.asc > log4j-distribution-2.0-beta6-src.zip > log4j-distribution-2.0-beta6-bin.zip.asc > log4j-distribution-2.0-beta6-src.zip.asc > log4j-distribution-2.0-beta6.pom.asc > log4j-distribution-2.0-beta6-bin.zip > log4j-distribution-2.0-beta6.pom > log4j-1.2-api-2.0-beta6-sources.jar > log4j-1.2-api-2.0-beta6-javadoc.jar > log4j-1.2-api-2.0-beta6-sources.jar.asc > log4j-1.2-api-2.0-beta6-javadoc.jar.asc > log4j-1.2-api-2.0-beta6.pom > log4j-1.2-api-2.0-beta6.jar > log4j-1.2-api-2.0-beta6.jar.asc > log4j-1.2-api-2.0-beta6.pom.asc > log4j-flume-ng-2.0-beta6.jar.asc > log4j-flume-ng-2.0-beta6-sources.jar.asc > log4j-flume-ng-2.0-beta6-sources.jar > log4j-flume-ng-2.0-beta6-javadoc.jar.asc > log4j-flume-ng-2.0-beta6.jar > log4j-flume-ng-2.0-beta6-tests.jar.asc > log4j-flume-ng-2.0-beta6-tests.jar > log4j-flume-ng-2.0-beta6-javadoc.jar > log4j-flume-ng-2.0-beta6.pom.asc > log4j-flume-ng-2.0-beta6.pom > log4j-to-slf4j-2.0-beta6-sources.jar > log4j-to-slf4j-2.0-beta6-sources.jar.asc > log4j-to-slf4j-2.0-beta6-javadoc.jar > log4j-to-slf4j-2.0-beta6.jar > log4j-to-slf4j-2.0-beta6.jar.asc > log4j-to-slf4j-2.0-beta6.pom > log4j-to-slf4j-2.0-beta6-javadoc.jar.asc > log4j-to-slf4j-2.0-beta6.pom.asc > log4j-api-2.0-beta6.jar.asc > log4j-api-2.0-beta6-sources.jar > log4j-api-2.0-beta6-javadoc.jar > log4j-api-2.0-beta6.pom.asc > log4j-api-2.0-beta6-javadoc.jar.asc > log4j-api-2.0-beta6.pom > log4j-api-2.0-beta6.jar > log4j-api-2.0-beta6-sources.jar.asc > log4j-core-2.0-beta6.jar > log4j-core-2.0-beta6-sources.jar > log4j-core-2.0-beta6-sources.jar.asc > log4j-core-2.0-beta6-tests.jar > log4j-core-2.0-beta6-javadoc.jar.asc > log4j-core-2.0-beta6.jar.asc > log4j-core-2.0-beta6-javadoc.jar > log4j-core-2.0-beta6.pom.asc > log4j-core-2.0-beta6-tests.jar.asc > log4j-core-2.0-beta6.pom > log4j-2.0-beta6.pom.asc > log4j-2.0-beta6.pom > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
