[ 
https://issues.apache.org/jira/browse/LOG4J2-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658302#comment-13658302
 ] 

Nick Williams commented on LOG4J2-10:
-------------------------------------

I need to point out a couple more things :-):

1) I'm not sure exactly what it does, but assuming the _removeheaders pattern 
is guaranteed consistent, it needs to also include JAVA_1_8_HOME (already lots 
of installations out there) and JAVA_1_9_HOME (people will start working on 
this soon). This needs to be changed elsewhere in the codebase, too, but that's 
a different issue.

2) I did forget one (tricky) dependency for core-osgi-jpa. Two classes, 
o.a.l.l.core.appender.db.jpa.converter.ContextMapJsonAttributeConverter and 
ContextStackJsonAttributeConverter, use Jackson Mapper. Now, if you use the JPA 
Appender out of the box, it doesn't use these. It uses the non-JSON equivalent 
ContextMapAttributeConverter and ContextStackAttributeConverter. You have to 
literally write code to override the mappings to tell it to use the JSON 
versions. So I think it's safe for Jackson Mapper to be an optional dependency 
here, but I wanted to make sure you knew.

Also, a question:

Since all of the changes in this patch technically add additional Maven 
submodules, does this affect the site? I don't think we want six extra 
components to show up on the site. Have you `mvn site` to check on this? The 
Maven site plugin needs to skip these altogether.
                
> log4j 2.0 should work well with OSGi and Apache Felix
> -----------------------------------------------------
>
>                 Key: LOG4J2-10
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-10
>             Project: Log4j 2
>          Issue Type: Wish
>            Reporter: Curt Arnold
>         Attachments: reduced-dependency-bundles-2.patch, 
> reduced-dependency-bundles.patch
>
>
> OSGi and specifically the Apache Felix implementation should be considered 
> for framework services such as internal logging and configuration.
> log4j 2.0 should be able to be a provider of OSGi logging services.
> OSGi package visibility declarations should be used to distinguish between 
> exported and explicitly supported APIs and implementation specific details. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to