[
https://issues.apache.org/jira/browse/LOG4J2-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661817#comment-13661817
]
Ralph Goers commented on LOG4J2-243:
------------------------------------
Overriding LoggerConfig is going to make you very vulnerable to changes in the
internals of Log4j. If you just want to implement your own createEvent than
perhaps this enhancement should be to allow a custom LogEventFactory to be
used. That was actually the reason for creating a separate interface in the
first place. If that will work then the description of this issue should be
changed.
> LoggerConfig has a method that should be protected instead of private.
> ----------------------------------------------------------------------
>
> Key: LOG4J2-243
> URL: https://issues.apache.org/jira/browse/LOG4J2-243
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0-beta6
> Reporter: Kurt Lehrke
> Priority: Minor
>
> LoggerConfig has a protected constructor that has an argument called
> includeLocation (boolean). When log4j2 calls this constructor they use the
> private static boolean includeLocation method to determine this argument.
> Since it's private, I cannot call it. I would like to suggest this to be
> changed to a protected method instead. That way, I don't have to duplicate
> the method in order to call this constructor, especially since it's
> specifically for the protected constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
