[ 
https://issues.apache.org/jira/browse/LOG4J2-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691602#comment-13691602
 ] 

Remko Popma commented on LOG4J2-267:
------------------------------------

Thomas, you also provided a patch for RollingFileManager, but I don't see why 
this is needed as it _creates_ the file just before gettings its LastModified 
time (as opposed to the Fast version which may _delete_ the old file).
Your patch looks fine for FastRollingFileManager (still need to do a quick test 
before I commit), but I think RollingFileManager is fine as is, or am I missing 
something?
                
> FastRollingFileAppender doesn't work well with TimeBasedTriggeringPolicy
> ------------------------------------------------------------------------
>
>                 Key: LOG4J2-267
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-267
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.0-beta6
>         Environment: Win7 SP1 64bit + JDK 6u43 64bit
>            Reporter: ilynaf
>            Assignee: Remko Popma
>         Attachments: LOG4J2-267.patch
>
>
> The below configuration file doesn't deliver correct rollover. As soon as 
> logging starts, the log file is rolled over with this date "1970-01-01". The 
> same configuration work fine with RollingFile appender.
> <configuration>
>     <appenders>
>         <FastRollingFile name="LogFile" fileName="log/ui-selenium-tests.log" 
> append="false"
>                            
> filePattern="log/ui-selenium-tests.%d{yyyy-MM-dd}.log">
>             <ThresholdFilter level="INFO" onMatch="ACCEPT" onMismatch="DENY"/>
>             <PatternLayout pattern="%d %p [%c.%M():%L] - %m%n"/>
>             <Policies>
>                 <TimeBasedTriggeringPolicy interval="1" modulate="true"/>
>             </Policies>
>             <DefaultRolloverStrategy/>
>         </FastRollingFile >
>     </appenders>
>     <loggers>
>         <root level="TRACE">
>             <appender-ref ref="LogFile"/>
>         </root>
>   </loggers>
> </configuratio

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to