The impl is:
@Override
public void add(final org.slf4j.Marker reference) {
super.add(reference);
((MarkerWrapper) reference).setParent(this);
}
and the super.add impl IS synchronized so either this is a subtle bug or it
should be documented, even if it is just an in-line comment.
Gary
On Thu, Aug 15, 2013 at 9:53 AM, Ralph Goers <[email protected]>wrote:
> What is synchronizing this method going to achieve?
>
> Ralph
>
> On Aug 15, 2013, at 6:39 AM, Gary Gregory wrote:
>
> Should org.slf4j.helpers.MarkerWrapper.add(Marker) be synchronized? The
> super impl is.
>
> Gary
>
> --
> E-Mail: [email protected] | [email protected]
> Java Persistence with Hibernate, Second
> Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: [email protected] | [email protected]
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
