I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
Ralph On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote: > On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <scott.de...@gmail.com> wrote: > I'm not sure if this ship has fully sailed, but I'd prefer to see us > stick with he dash format due to folks being familiar with it from > log4j 1. > > That's a thin argument IMO considering you'll have to read the version 2 > config docs to get off the ground anyway, even if you know your way around > version 1. > > And this is also an opportunity to make our config code even fancier by > normalizing '-' chars ;) > > Gary > > > Gary > > > Scott > > On 8/16/13, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers > > <ralph.go...@dslextreme.com>wrote: > > > >> I'm adding an aliases attribute to the Plugin annotation. > >> > > > > Hold on to your horses ;) > > > > Another way to look at this is that our config parsing that is already > > case-insensitive could be augmented to strip out "-"s, no aliases needed. > > > > As someone pointed out here, some folks like-to-talk-like-this (see JPA). > > > > Gary > > > > > >> > >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote: > >> > >> Maybe we just need another plugin for the 2nd name then. Subclass or > >> delegate? > >> > >> On Friday, August 16, 2013, Ralph Goers wrote: > >> > >>> I had the same thought. People switching from log4j 1 or logback will > >>> probably make that mistake a lot. Plus this breaks virtually everyone > >>> currently using Log4j 2. The problem is that I don't think there is > >>> currently a way for a plugin to have 2 names. > >>> > >>> Sent from my iPad > >>> > >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <remko.po...@gmail.com> wrote: > >>> > >>> Would it be an idea to support both appender-ref and appenderRef > >>> attributes? > >>> > >>> > >>> > >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory > >>> <garydgreg...@gmail.com>wrote: > >>> > >>> I never thought that Log4J 2 configuration files should be backward > >>> compatible with version 1, and even less so with a different product. > >>> > >>> Gary > >>> > >>> > >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers > >>> <ralph.go...@dslextreme.com>wrote: > >>> > >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both > >>> use > >>> appender-ref. Anyone using Log4j 2 will now be broken. > >>> > >>> On Aug 14, 2013, at 1:05 PM, ggreg...@apache.org wrote: > >>> > >>> > Modified: > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml > >>> > URL: > >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff > >>> > > >>> ============================================================================== > >>> > --- > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml > >>> (original) > >>> > +++ > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed > >>> Aug 14 20:05:54 2013 > >>> > @@ -30,10 +30,10 @@ > >>> > </appenders> > >>> > <loggers> > >>> > <logger name="org.apache.test" level="trace" additivity="false"> > >>> > - <appender-ref ref="List"/> > >>> > + <AppenderRef ref="List"/> > >>> > </logger> > >>> > <root level="error"> > >>> > - <appender-ref ref="STDOUT"/> > >>> > + <AppenderRef ref="STDOUT"/> > >>> > </root> > >>> > </loggers> > >>> > </configuration> > >>> > \ No newline at end of file > >>> > > >>> > Modified: > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml > >>> > URL: > >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff > >>> > > >>> ============================================================================== > >>> > --- > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml > >>> (original) > >>> > +++ > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml > >>> Wed Aug 14 20:05:54 2013 > >>> > @@ -25,7 +25,7 @@ > >>> > <loggers> > >>> > <logger name="org.foo" level="DEBUG" /> > >>> > <root level="TRACE"> > >>> > - <appender-ref ref="Console" /> > >>> > + <AppenderRef ref="Console" /> > >>> > </root> > >>> > </loggers> > >>> > </configuration> > >>> > \ No newline at end of file > >>> > > >>> > Modified: > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml > >>> > URL: > >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff > >>> > > >>> ============================================================================== > >>> > --- > >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml > >>> (original) > >>> > >>> > >> > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second > > Edition<http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org > For additional commands, e-mail: log4j-dev-h...@logging.apache.org > > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
