A couple of thoughts. a) Is PluginAttribute really any clearer than PluginAttr? b) Take a look at the SyslogAppender, JMSTopicAppender and some of the other ones. Changing PluginAttr to PluginAttribute adds 5 more characters to the lines. That may not seem like much but it forces the arguments to JMSTopicAppender to all be shifted to the left to avoid exceeding the line length. I'm guessing that if you did this you would probably do a mass change. But then you would have to run checkstyle and fix all the classes that you just created errors in.
Other than that, if the consensus is to change it I have no objection. Raph On Aug 19, 2013, at 7:56 AM, Gary Gregory wrote: > Hi All: > > I think we should rename PluginAttr to PluginAttribute, it is the only > annotation that is abbreviated in the package. For example, PluginElement and > PluginConfiguration are not abbreviated. > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
