If the commit set is truly atomic, Git might "solve" the problem of a big-bang commit in the same way that multiple patch files would. Yes, you would have a step by step commit set BUT you would not have everything compiling and running at each step. If keeping the code compiling and testing cleanly is not possible, then one fat commit it is ;) My 2c that is.
Gary On Mon, Mar 24, 2014 at 11:00 AM, Matt Sicker <[email protected]> wrote: > I wanted to do that, but there were a lot of cross-dependencies. I didn't > want to commit anything that broke the build. There's still more > refactoring I wanted to do, so I figured it'd be best to get a working > refactoring committed first. This would be easier in git ;) > > Any advice on how I might go about doing staging and such like you can in > git via svn? > > > On 24 March 2014 07:30, Gary Gregory <[email protected]> wrote: > >> In the future, I think it would be best, when possible, to break down >> commits in smaller chunks that are easier to review. >> >> Gary >> >> >> On Mon, Mar 24, 2014 at 12:17 AM, <[email protected]> wrote: >> >> > Author: mattsicker >> > Date: Mon Mar 24 04:17:35 2014 >> > New Revision: 1580734 >> > >> > URL: http://svn.apache.org/r1580734 >> > Log: >> > Config Refactor. >> > >> > - Modified StatusLogger.getListeners() to return an Iterable >> > instead of an Iterator for convenience. >> > - Renamed BasicConfiguration to AbstractConfiguration. >> > - Pulled up the toByteArray method from XML/JSONConfiguration. >> > - Moved the three XML/YAML/JSONConfigurations to their own packages. >> > - Created a StatusConfiguration builder for setting up StatusLogger >> > and reducing redundant code. >> > - Simplified constructors for configuration classes (still needs >> > work; there's a lot of commonality between the two main ones still). >> > - Migrated some status logging to use parameters. >> > - Fixed some potential bugs in a couple places: >> > * Saw a configuration element name being interpolated. >> > * Modified the status dest attribute to be interpolated. >> > * Prevented an NPE if the given file URI for the status logger >> > doesn't exist. >> > >> > Added: >> > >> > >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java >> > - copied, changed from r1580711, >> > >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/BaseConfiguration.java >> > >> > >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/json/ >> > >> > >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/json/JSONConfiguration.java >> > - copied, changed from r1580711, >> > >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/JSONConfiguration.java >> > >> > >> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/json/JSONConfigurationFa >> >> ----- Message truncated ----- >> >> >> >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second >> Edition<http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > Matt Sicker <[email protected]> > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
