I'll make this change soon unless someone pipes up.
Gary
On Mon, Mar 24, 2014 at 3:33 PM, Matt Sicker <boa...@gmail.com> wrote:
> Being a wrapper class tends to mean concrete in my experience, so it would
> make sense to shorten it to LoggerProviderWrapper. The old
> AbstractLoggerWrapper name would have made more sense as LoggerWrapper
> anyhow (unless it was abstract).
>
>
> On 24 March 2014 01:03, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> Also now public class AbstractLoggerProviderWrapper extends
>> AbstractLoggerProvider but it is not abstract.
>>
>> If it is intended to be, let's declare it as such or drop the "Abstract"
>> from the name.
>>
>> Gary
>>
>>
>> On Mon, Mar 24, 2014 at 1:59 AM, Gary Gregory <garydgreg...@gmail.com>wrote:
>>
>>> In the same vein: AbstractLogger -> AbstractLoggerProvider since it
>>> implements LoggerProvider.
>>>
>>> Gary
>>>
>>>
>>> On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>>> Sounds like a good idea.
>>>>
>>>>
>>>> On 23 March 2014 21:20, Gary Gregory <garydgreg...@gmail.com> wrote:
>>>>
>>>>> Now that AbstractLoggerWrapper looks like this:
>>>>>
>>>>> public class AbstractLoggerWrapper extends AbstractLogger {
>>>>>
>>>>> /**
>>>>> * The wrapped Logger.
>>>>> */
>>>>> protected final LoggerProvider logger;
>>>>>
>>>>> Should rename AbstractLoggerWrapper to LoggerProviderWrapper?
>>>>>
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>> Java Persistence with Hibernate, Second
>>>>> Edition<http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <boa...@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second
>>> Edition<http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second
>> Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker <boa...@gmail.com>
>
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
