Almost sounds like the job for a Comparator or Comparable<Level>. Then again, the ability to put an int in there might prevent that.
On 24 March 2014 15:16, Gary Gregory <[email protected]> wrote: > In the Level class we have: > > org.apache.logging.log4j.Level.isAtLeastAsSpecificAs(int) > org.apache.logging.log4j.Level.isAtLeastAsSpecificAs(Level) > > Which is implemented the same as way: > > org.apache.logging.log4j.Level.isLessOrEqual(int) > org.apache.logging.log4j.Level.isLessOrEqual(Level) > > For compatibility with 1.2 (the server I am porting to v2 does not > compile), I added: > > org.apache.logging.log4j.Level.isGreaterOrEqual(Level) > > and to match the above I also added: > > org.apache.logging.log4j.Level.isGreaterOrEqual(int) > > What to do about the duplication? > > Internally we use isAtLeastAsSpecificAs(). > > I am inclined to dump isAtLeastAsSpecificAs in favor of isLessOrEqual. > > Thoughts? > > Gary > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second > Edition<http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <[email protected]>
