AbstractConfigurationTest is a confusing name. It is not abstract and it is not subclassed. Better name?
Gary On Sun, Mar 23, 2014 at 9:19 PM, Matt Sicker <boa...@gmail.com> wrote: > Interesting. There's already an AbstractConfigurationTest that's an > abstract ConfigurationTest, but there's also a BaseConfigurationTest. > > > On 23 March 2014 19:57, Matt Sicker <boa...@gmail.com> wrote: > >> I like it. Will include in the refactoring I'm working on. >> >> >> On 23 March 2014 19:12, Gary Gregory <garydgreg...@gmail.com> wrote: >> >>> How about calling it AbstractConfiguration now that it is abstract? >>> >>> Gary >>> >>> ---------- Forwarded message ---------- >>> From: <mattsic...@apache.org> >>> Date: Sun, Mar 23, 2014 at 5:21 PM >>> Subject: svn commit: r1580614 - >>> /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/BaseConfiguration.java >>> To: comm...@logging.apache.org >>> >>> >>> Author: mattsicker >>> Date: Sun Mar 23 21:21:41 2014 >>> New Revision: 1580614 >>> >>> URL: http://svn.apache.org/r1580614 >>> Log: >>> Make o.a.l.l.c.config.BaseConfiguration abstract. >>> >>> - Removed unused field. >>> - Using this as an abstract class to help refactor these >>> configuration classes. >>> >>> Modified: >>> >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/BaseConfiguration.java >>> >>> Modified: >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/BaseConfiguration.java >>> URL: >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/BaseConfiguration.java?rev=1580614&r1=1580613&r2=1580614&view=diff >>> >>> ============================================================================== >>> --- >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/BaseConfiguration.java >>> (original) >>> +++ >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/BaseConfiguration.java >>> Sun Mar 23 21:21:41 2014 >>> @@ -69,9 +69,7 @@ import org.apache.logging.log4j.util.Pro >>> /** >>> * The Base Configuration. Many configuration implementations will >>> extend this class. >>> */ >>> -public class BaseConfiguration extends AbstractFilterable implements >>> Configuration { >>> - >>> - static final String PACKAGE_SEPARATOR = "\\s*,\\s*"; >>> +public abstract class BaseConfiguration extends AbstractFilterable >>> implements Configuration { >>> >>> /** >>> * Allow subclasses access to the status logger without creating >>> another instance. >>> >>> >>> >>> >>> >>> -- >>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>> Java Persistence with Hibernate, Second >>> Edition<http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >> >> >> >> -- >> Matt Sicker <boa...@gmail.com> >> > > > > -- > Matt Sicker <boa...@gmail.com> > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
