It's always null due to the null check beforehand.
On Thursday, 3 April 2014, Remko Popma <[email protected]> wrote:
> Matt,
> In FormattedMessage.writeObject
> Why did you remove the throwable?
>
> if (message == null) {
> - message = getMessage(messagePattern, argArray, throwable);
> + message = getMessage(messagePattern, argArray, null);
> }
>
> On Friday, April 4, 2014,
> <[email protected]<javascript:_e(%7B%7D,'cvml','[email protected]');>>
> wrote:
>
>> Author: mattsicker
>> Date: Thu Apr 3 23:28:55 2014
>> New Revision: 1584469
>>
>> URL: http://svn.apache.org/r1584469
>> Log:
>> Replace single char strings with chars.
>>
>> Modified:
>>
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
>>
>> Modified:
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
>> URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java?rev=1584469&r1=1584468&r2=1584469&view=diff
>>
>> ==============================================================================
>> ---
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
>> (original)
>> +++
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
>> Thu Apr 3 23:28:55 2014
>> @@ -164,7 +164,7 @@ public class FormattedMessage implements
>> @Override
>> public String toString() {
>> return "FormattedMessage[messagePattern=" + messagePattern + ",
>> args=" +
>> - Arrays.toString(argArray) + "]";
>> + Arrays.toString(argArray) + ']';
>> }
>>
>> private void writeObject(final ObjectOutputStream out) throws
>> IOException {
>> @@ -203,7 +203,7 @@ public class FormattedMessage implements
>> return throwable;
>> }
>> if (message == null) {
>> - message = getMessage(messagePattern, argArray, throwable);
>> + message = getMessage(messagePattern, argArray, null);
>> }
>> return message.getThrowable();
>> }
>>
>>
>>
--
Matt Sicker <[email protected]>
