FileOutputTest was failing because the status level was changed to OFF and the test is expecting status logs to be written to a file. I’m not sure how why this commit was ever done since a “mvn clean install” would have failed. Let me reiterate one more time. If the unit tests fail don’t commit - you did something wrong as the unit tests should ALWAYS pass.
Ralph On Apr 26, 2014, at 10:30 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote: > The error in CustomConfigurationTest is now fixed. On to FileOutputTest. > > Ralph > > On Apr 26, 2014, at 10:23 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote: > >> I finally got a chance to look at CustomConfigurationTest. As I suspected >> the unit test is incorrect. >> >> A check was added to see if the StatusLogger’s level was changed to info. >> However, setting status=“info” doesn’t change the level of the Logger >> attached to the status logger. It changes the Level associated with the >> ConsoleListener added by the configuration. So this error has nothing to do >> with LOG4J2-607. >> >> I should have a fix committed in a little bit. >> >> Ralph >> >> On Apr 21, 2014, at 12:03 AM, Matt Sicker <boa...@gmail.com> wrote: >> >>> The first unit test failure there is due to LOG4J2-607. The second: not >>> sure. >>> >>> >>> On 21 April 2014 00:05, Ralph Goers <ralph.go...@dslextreme.com> wrote: >>> I just did a fresh checkout and am getting the following test failures: >>> >>> >>> Results : >>> >>> Failed tests: >>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO> >>> FileOutputTest.testConfig:44 File is empty >>> >>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15 >>> >>> >>> >>> -- >>> Matt Sicker <boa...@gmail.com> >> >
