On Thu, May 1, 2014 at 7:27 PM, Remko Popma <[email protected]> wrote:
> ASAIKS, there are currently only two places that use > System.currentTimeMillis() for creating the log event timestamp: > * one of the Log4jLogEvent constructors > * PatternProcessor#formatFileName - the log event created here is a > temporary object used only by the StrSubstitutor > > Not 100% sure about the PatternProcessor#formatFileName... Use > configurable time or system time here? > I think so based on the user story right? As a user, I want to simulate a different time on the system, so that timestamps in the log are determined by my custom clock. I would assume that includes timestamps is other artifacts like file names. It would be good to hear back from the user here. Gary > > > > On Fri, May 2, 2014 at 8:11 AM, Remko Popma <[email protected]> wrote: > >> In recent Jira ticket LOG4J2-628 "Cannot set log4j.Clock with Async >> appender", the user requests that all log event timestamps are generated >> from the a configurable Clock. Currently only log event timestamps >> generated by Async Loggers are configurable. >> >> I think it makes sense to do this. >> I propose to limit the scope of Clock to log event timestamps only. >> I don't propose to use the Clock internally for things like thread >> timeouts. >> >> Thoughts? >> >> Remko >> > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
