That's a nifty change. It's supposed to be the default option, too. I made the forkCount 2C.
On 18 May 2014 20:05, Matt Sicker <[email protected]> wrote: > Oh I thought I read it said false. Should I keep the forkCount, too? > > > On 18 May 2014 19:50, Remko Popma <[email protected]> wrote: > >> Matt, >> Sorry, I should have documented this in the pom, but log4j-api can run >> junit tests with <reuseForks>true</reuseForks>, which reduces the build >> time from 22 to 10 seconds. >> It looks redundant but is slightly different from the default >> (reuseforks=false). Again, I should've put a comment in the pom... >> >> Can you revert this change? >> >> I'd like log4j-core to be able to run junit tests with this setting but >> that may not be easy... >> >> Remko >> >> Sent from my iPhone >> >> > On 2014/05/19, at 6:20, [email protected] wrote: >> > >> > Author: mattsicker >> > Date: Sun May 18 21:20:58 2014 >> > New Revision: 1595692 >> > >> > URL: http://svn.apache.org/r1595692 >> > Log: >> > Remove redundant surefire configuration. >> > >> > Modified: >> > logging/log4j/log4j2/trunk/log4j-api/pom.xml >> > >> > Modified: logging/log4j/log4j2/trunk/log4j-api/pom.xml >> > URL: >> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/pom.xml?rev=1595692&r1=1595691&r2=1595692&view=diff >> > >> ============================================================================== >> > --- logging/log4j/log4j2/trunk/log4j-api/pom.xml (original) >> > +++ logging/log4j/log4j2/trunk/log4j-api/pom.xml Sun May 18 21:20:58 >> 2014 >> > @@ -66,11 +66,6 @@ >> > <plugin> >> > <groupId>org.apache.maven.plugins</groupId> >> > <artifactId>maven-surefire-plugin</artifactId> >> > - <configuration> >> > - <argLine>-Xms256m -Xmx1024m -XX:MaxPermSize=512m</argLine> >> > - <forkCount>1</forkCount> >> > - <reuseForks>true</reuseForks> >> > - </configuration> >> > </plugin> >> > <plugin> >> > <groupId>org.apache.maven.plugins</groupId> >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > -- > Matt Sicker <[email protected]> > -- Matt Sicker <[email protected]>
