Yes, the test fails on my machine. I have an idea on how to fix this by borrowing a class from Camel for finding an available port to use. I think there's port conflict issues in all the network tests.
I'll mark it as @Ignore for now and will spend some time later today working on that. On 21 May 2014 10:59, Remko Popma <[email protected]> wrote: > In my previous message I was assuming that the test also fails on your > machine. Is that the case? > > > On Thu, May 22, 2014 at 12:54 AM, Remko Popma <[email protected]>wrote: > >> So, before the change, the test was printing an error message but did not >> fail. >> After the change, the test fails. >> >> This breaks the build. >> Please fix this: if there really is a problem then the class under test >> needs to be fixed. Or perhaps the test is wrong or too strict? >> As a stopgap, if you don't have time to work on this, you can mark the >> test with @ignore and revisit this later. >> >> But please don't leave it in a broken state. >> >> >> >> On Wed, May 21, 2014 at 11:13 PM, Matt Sicker <[email protected]> wrote: >> >>> I've been getting that error in my logs every time. Now that I made the >>> configuration explicit, the test finally fails. I really doubt the issue is >>> the class rule. This test has been failing for a while as far as I've >>> noticed. >>> >>> >>> On 21 May 2014 08:35, Gary Gregory <[email protected]> wrote: >>> >>>> Can you all run org.apache.logging.log4j.core.net.SocketMessageLossTest >>>> OK? >>>> >>>> Is the failure I am seeing due to the recent @ClassRule change? >>>> >>>> org.apache.logging.log4j.core.appender.AppenderLoggingException: Error >>>> writing to TCP:localhost:5514 socket not available >>>> at >>>> org.apache.logging.log4j.core.net.TcpSocketManager.write(TcpSocketManager.java:120) >>>> at >>>> org.apache.logging.log4j.core.appender.OutputStreamManager.write(OutputStreamManager.java:127) >>>> at >>>> org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.append(AbstractOutputStreamAppender.java:120) >>>> at >>>> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:97) >>>> at >>>> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:429) >>>> at >>>> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:408) >>>> at >>>> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:368) >>>> at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:103) >>>> at >>>> org.apache.logging.log4j.spi.AbstractLoggerProvider.logMessage(AbstractLoggerProvider.java:1336) >>>> at >>>> org.apache.logging.log4j.spi.AbstractLoggerProvider.logIfEnabled(AbstractLoggerProvider.java:1325) >>>> at >>>> org.apache.logging.log4j.spi.AbstractLoggerProvider.error(AbstractLoggerProvider.java:528) >>>> at >>>> org.apache.logging.log4j.core.net.SocketMessageLossTest.testSocket(SocketMessageLossTest.java:62) >>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) >>>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) >>>> at java.lang.reflect.Method.invoke(Unknown Source) >>>> at >>>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) >>>> at >>>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) >>>> at >>>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) >>>> at >>>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) >>>> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) >>>> at >>>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) >>>> at >>>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) >>>> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) >>>> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) >>>> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) >>>> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) >>>> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) >>>> at >>>> org.apache.logging.log4j.junit.InitialLoggerContext$1.evaluate(InitialLoggerContext.java:59) >>>> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >>>> at org.junit.runners.ParentRunner.run(ParentRunner.java:309) >>>> at >>>> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50) >>>> at >>>> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) >>>> at >>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) >>>> at >>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) >>>> at >>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) >>>> at >>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) >>>> >>>> >>>> >>>> Gary >>>> >>>> -- >>>> E-Mail: [email protected] | [email protected] >>>> Java Persistence with Hibernate, Second >>>> Edition<http://www.manning.com/bauer3/> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>> Spring Batch in Action <http://www.manning.com/templier/> >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> >>> -- >>> Matt Sicker <[email protected]> >>> >> >> > -- Matt Sicker <[email protected]>
