I do not like having v to use two annotations. What not @PluginAttribute (name="someName", defaultValue=123)?
Gary <div>-------- Original message --------</div><div>From: [email protected] </div><div>Date:05/25/2014 00:05 (GMT-05:00) </div><div>To: [email protected] </div><div>Subject: svn commit: r1597377 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java </div><div> </div>Author: mattsicker Date: Sun May 25 04:05:52 2014 New Revision: 1597377 URL: http://svn.apache.org/r1597377 Log: Change Boolean to boolean in factory method. Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java?rev=1597377&r1=1597376&r2=1597377&view=diff ============================================================================== --- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java (original) +++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java Sun May 25 04:05:52 2014 @@ -181,7 +181,7 @@ public final class AsyncAppender extends @PluginFactory public static AsyncAppender createAppender(@PluginElement("AppenderRef") final AppenderRef[] appenderRefs, @PluginAttribute("errorRef") @PluginAliases("error-ref") final String errorRef, - @PluginAttribute("blocking") @PluginDefault("true") final Boolean blocking, + @PluginAttribute("blocking") @PluginDefault("true") final boolean blocking, @PluginAttribute("bufferSize") @PluginDefault(DEFAULT_QUEUE_SIZE) final int size, @PluginAttribute("name") final String name, @PluginAttribute("includeLocation") @PluginDefault("false") final boolean includeLocation,
