Hm... annotations do not work like that, if we renamed 'value' to 'name',
you cannot use the short hand @PluginElement("Layout"), you'd have to use
@PluginElement(name = "Layout")So I think we can drop this discussion... check? Gary On Wed, May 28, 2014 at 12:12 AM, Gary Gregory <[email protected]> wrote: > PluginAttribute.value() looks misnamed, why not call it "name"? > > This is better: > > @PluginFactory > public static ConsoleAppender createAppender( > @PluginElement("Layout") Layout<? extends Serializable> layout, > @PluginElement("Filters") final Filter filter, > @PluginAttribute(name= "target", defaultStringValue = > "SYSTEM_OUT") final String targetStr, > @PluginAttribute("name") final String name, > @PluginAttribute(name= "follow", defaultBooleanValue = false) > final String follow, > @PluginAttribute(name= "ignoreExceptions", defaultBooleanValue > = true) final String ignore) { > > than: > > @PluginFactory > public static ConsoleAppender createAppender( > @PluginElement("Layout") Layout<? extends Serializable> layout, > @PluginElement("Filters") final Filter filter, > @PluginAttribute(value = "target", defaultStringValue = > "SYSTEM_OUT") final String targetStr, > @PluginAttribute("name") final String name, > @PluginAttribute(value = "follow", defaultBooleanValue = > false) final String follow, > @PluginAttribute(value = "ignoreExceptions", > defaultBooleanValue = true) final String ignore) { > > IMO that is... > > Gary > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
