[
https://issues.apache.org/jira/browse/LOG4J2-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039969#comment-14039969
]
Mck SembWever commented on LOG4J2-673:
--------------------------------------
{quote}I do have an issue with you having to change the configuration files and
make the package element be required … it has never been required before.{quote}
In 2.0-rc1 you had to supply the packages to where plugins were found.
I do like the idea of removing the need for it, as was the intendion for 2.0-rc2
{quote}It would make more sense to just generate the files into a single
directory with each having its own name.{quote}
This can be done very easily. The simplicity of this approach has my vote. The
unique name need not be supplied to the annotation processor, it can be
determine in the same manner as the existing patch does.
{quote}In looking at the Shade plugin it allows "resource transformers".{quote}
I wonder if the following will work out-of-the-box…
{code}
<transformer
implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
<resource>META-INF/org/apache/logging/log4j/core/config/plugins/Log4j2Plugins.dat</resource>
</transformer>{code}
But i still like the mutliple files in a single directory approach, as it
provides a zero configuration for the client. (this is the same argument as
wanting to remove the need for packages).
> plugin preloading fails in shaded jar files
> -------------------------------------------
>
> Key: LOG4J2-673
> URL: https://issues.apache.org/jira/browse/LOG4J2-673
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0-rc2
> Reporter: Mck SembWever
> Priority: Critical
> Labels: annotations, compiler, plugins
> Fix For: 2.0-rc2
>
> Attachments:
> 0002-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch
>
>
> Support for plugin preloading through the standard
> javax.annotation.processing tool was adding in LOG4J2-595
> But the plugin processor always creates and stores the processed "Plugin"
> annotated classes into the same file. This works fine when the classpath
> consists of individual jar files, but fails when shaded jar files are used.
> A tested fix exists at
> https://github.com/finn-no/logging-log4j2/tree/bugfix/LOG4J2-673
> There's also a github pull request and a manual diff attached. (I can clean
> up anything not used afterwards)
> The fix saves the dat file in a location under META-INF that matches the
> shared package all the processed plugins are found under.
> The package attribute in the config file is then used so that multiple dat
> files can be loaded at runtime.
> This means that the package attribute is no longer deprecated.
> This has been tested against
> https://github.com/finn-no/log4j2-logstash-jsonevent-layout
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
