There are certainly a lot of checkstyle errors/warnings. I occasionally see Eclipse warning about an unused import or an unused private field, but checkstyle seems a lot stricter...
I'll try to spend some time cleaning this up after rc2 is out. I noticed that we occasionally break the checkstyle rules on purpose. For example, in slf4j-impl, StaticLoggerBinder.REQUESTED_API_VERSION is not final on purpose. We should consider adding this module to the checkstyle.xml config: <module name="SuppressionCommentFilter"/> That would allow us to switch checkstyle off for specific lines of code. Like this: //CHECKSTYLE:OFF public void someMethod(String arg1, String arg2, String arg3, String arg4) { //CHECKSTYLE:ON You can even switch off only specific checks (see http://stackoverflow.com/questions/4023185/how-to-disable-a-particular-checkstyle-rule-for-a-particular-line-of-code ). On Sat, Jun 21, 2014 at 6:08 AM, Matt Sicker <boa...@gmail.com> wrote: > Probably a combination of both. > > > On 19 June 2014 22:43, Ralph Goers <ralph.go...@dslextreme.com> wrote: > >> Either our the checkstyle rules must not match the IDE rules as we have >> hundreds of checkstyle errors in the reports. >> >> Ralph >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org >> For additional commands, e-mail: log4j-dev-h...@logging.apache.org >> >> > > > -- > Matt Sicker <boa...@gmail.com> >