NoSQL doesn't have the concept of commits and transactions. Plus, closeAndCommit() was just calling close() when non-null, so it was a simple change overall. :)
On 22 June 2014 18:33, Remko Popma <[email protected]> wrote: > (Away from PC) > Is this.commitAndClose(); really the same as Closer.closeSilent? > > Closer only closes and does not commit... > > Sent from my iPhone > > > On 2014/06/23, at 3:15, [email protected] wrote: > > > > Author: mattsicker > > Date: Sun Jun 22 18:15:20 2014 > > New Revision: 1604632 > > > > URL: http://svn.apache.org/r1604632 > > Log: > > Use Closer methods. > > > > Modified: > > > > logging/log4j/log4j2/trunk/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/NoSQLDatabaseManager.java > > > > Modified: > logging/log4j/log4j2/trunk/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/NoSQLDatabaseManager.java > > URL: > http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/NoSQLDatabaseManager.java?rev=1604632&r1=1604631&r2=1604632&view=diff > > > ============================================================================== > > --- > logging/log4j/log4j2/trunk/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/NoSQLDatabaseManager.java > (original) > > +++ > logging/log4j/log4j2/trunk/log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/NoSQLDatabaseManager.java > Sun Jun 22 18:15:20 2014 > > @@ -24,6 +24,7 @@ import org.apache.logging.log4j.core.Log > > import org.apache.logging.log4j.core.appender.AppenderLoggingException; > > import org.apache.logging.log4j.core.appender.ManagerFactory; > > import org.apache.logging.log4j.core.appender.db.AbstractDatabaseManager; > > +import org.apache.logging.log4j.core.util.Closer; > > > > /** > > * An {@link AbstractDatabaseManager} implementation for all NoSQL > databases. > > @@ -50,9 +51,7 @@ public final class NoSQLDatabaseManager< > > > > @Override > > protected void shutdownInternal() { > > - if (this.connection != null) { > > - this.commitAndClose(); > > - } > > + Closer.closeSilent(this.connection); > > } > > > > @Override > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Matt Sicker <[email protected]>
