[ 
https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062229#comment-14062229
 ] 

Remko Popma commented on LOG4J2-609:
------------------------------------

About changing the {{StatusData}} constructor, this breaks the API, but I don't 
see what benefit we or the users are getting in return... So why then make the 
change?

About removing the ability to switch StatusLogger output on/off in 
reconfiguration, do we really want to do that? It sounds like a good feature 
for our users.

To be honest I'm not clear on how things work with/without the 
StatusConsoleListener. If that is not registered, shouldn't StatusLogger still 
log to the console since it delegates to a SimpleLogger instance that logs to 
System.err? (I'm actually not sure if there is any code that checks if 
StatusLogger.isEnabled before calling StatusLogger.warn/info/debug, so perhaps 
my concern was not realistic.) So perhaps users would see StatusLogger output 
even with only the api jar...

> StatusConfiguration doesn't close files
> ---------------------------------------
>
>                 Key: LOG4J2-609
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-609
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0-rc1
>            Reporter: Bruce Brouwer
>            Assignee: Ralph Goers
>         Attachments: LOG4J2-609.unfinished.patch, log4j2-609.patch
>
>
> {{org.apache.logging.log4j.core.config.status.StatusConfiguration}} allows 
> you to specify a destination such as "out", "err" or a file name. If 
> specifying a file, that file stream is used when creating a 
> {{StatusConsoleListener}} that is added to the {{StatusLogger}}. Those 
> {{StatusLogger}} listeners are never cleaned up when, for example, the 
> {{XmlConfiguration}} is reconfigured or when the {{LoggerContext}} is shut 
> down (e.g. in {{InitialLoggerContext.apply()}}). This leaves open file 
> handles and is the source of the failing test {{FileOutputTest}} on Windows. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to