[
https://issues.apache.org/jira/browse/LOG4J2-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091769#comment-14091769
]
Gary Gregory commented on LOG4J2-715:
-------------------------------------
Hi Matt,
The patch looks OK but... since {{AbstractDatabaseManager}} implements
{{LifeCycle}} it must manage its own state, which it does, so that good :-) But
it does so differently than how {{AbstractLifeCycle}} is implemented. So my
question is, why use volatile in one case and concurrent utils here?
So looking ahead, should {{AbstractManager}} extend {{AbstractLifeCycle}}? It
does not seem like a perfect fit at first glance, perhaps because of the
reference counting. Thoughts on that?
> org.apache.logging.log4j.core.appender.db.AbstractDatabaseManager should
> implement org.apache.logging.log4j.core.LifeCycle
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: LOG4J2-715
> URL: https://issues.apache.org/jira/browse/LOG4J2-715
> Project: Log4j 2
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 2.0
> Environment: Apache Maven 3.2.2
> (45f7c06d68e745d05611f7fd14efb6594181933e; 2014-06-17T09:51:42-04:00)
> Maven home: C:\Java\apache-maven-3.2.2
> Java version: 1.7.0_60, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_60\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Gary Gregory
> Assignee: Matt Sicker
> Attachments: AbstractDatabaseManager_LifeCycle.patch
>
>
> {{org.apache.logging.log4j.core.appender.db.AbstractDatabaseManager}} should
> implement {{org.apache.logging.log4j.core.LifeCycle}} instead of inventing
> its own life cycle methods.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
