If you have an ivar foo and you declare a foo parameter or local, you can
no longer access the ivar (unless you use 'this'). Most compilers can warn
you about this (as Eclipse does) unless you are a special case like a
setter method where the pattern is "set(T foo) { this.foo = foo; }". In the
style guidelines I use, this produces a compiler warning.Gary On Fri, Aug 29, 2014 at 1:43 AM, Ralph Goers <[email protected]> wrote: > What does this comment mean? What was "hidden" that is now not hidden. All > I see is a variable renamed - and why the new name is better than the old > escapes me. > > Ralph > > Begin forwarded message: > > *From: *[email protected] > *Subject: **svn commit: r1620442 - > /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataMessage.java* > *Date: *August 25, 2014 at 2:08:57 PM MST > *To: *[email protected] > *Reply-To: *[email protected] > > Author: ggregory > Date: Mon Aug 25 21:08:57 2014 > New Revision: 1620442 > > URL: http://svn.apache.org/r1620442 > Log: > Don't hide ivar. > > Modified: > > > logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataMessage.java > > Modified: > logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataMessage.java > URL: > http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataMessage.java?rev=1620442&r1=1620441&r2=1620442&view=diff > > ============================================================================== > --- > logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataMessage.java > (original) > +++ > logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataMessage.java > Mon Aug 25 21:08:57 2014 > @@ -250,8 +250,8 @@ public class StructuredDataMessage exten > final StringBuilder sb = new StringBuilder(); > final boolean full = Format.FULL.equals(format); > if (full) { > - final String type = getType(); > - if (type == null) { > + final String myType = getType(); > + if (myType == null) { > return sb.toString(); > } > sb.append(getType()).append(' '); > > > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
