Gary, Thanks for looking at this! I had a look at the patch. Some feedback: * Good idea to have a Clock.stop() method * As you indicated, it may be a good idea to call ClockFactory.getClock().stop() in the loggerContext stop() method. That way non-webapps can benefit too. * We may need a Clock.start() method in loggerContext.start() then when a webapp is reloaded. - but newContext.start() may get called before oldContext.stop()! Need a refCount mechanism?? * An alternative to creating a new class StopFlagThread is to call thread.interrupt() in the stop() method, and check if interrupted() returns true in the while loop: while (!interrupted()). But creating a new class works just as well.
Tiny detail: there is a log file log4j-core/LOG4J2-807.log in the patch. On Wed, Sep 10, 2014 at 11:09 PM, Gary Gregory <[email protected]> wrote: > Hi All: > > I am looking for feedback on my patch in > https://issues.apache.org/jira/browse/LOG4J2-819 > > Thank you , > Gary > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory >
