[
https://issues.apache.org/jira/browse/LOG4J2-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137110#comment-14137110
]
Gary Gregory commented on LOG4J2-834:
-------------------------------------
LOG4J2-832 says that an {{Error}} can be thrown, the fix there is to catch
{{Throwable}} but this is not easy to test without hard coding a dependency on
a {{sun.}} class.
> NoClassDefFoundError in ThrowableProxy
> --------------------------------------
>
> Key: LOG4J2-834
> URL: https://issues.apache.org/jira/browse/LOG4J2-834
> Project: Log4j 2
> Issue Type: Bug
> Reporter: Nikita Koval
>
> In method *loadClass* we expect {{ClassNotFoundException}}. But if class
> comes from another java machine we can get {{NoClassDefFoundError}}.
> Possible fix:
> {code:java}
> private Class<?> loadClass(final ClassLoader lastLoader, final String
> className) {
> // XXX: this is overly complicated
> Class<?> clazz;
> if (lastLoader != null) {
> try {
> clazz = Loader.initializeClass(className, lastLoader);
> if (clazz != null) {
> return clazz;
> }
> } catch (final Throwable ignore) {
> // Ignore exception.
> }
> }
> try {
> clazz = Loader.loadClass(className);
> } catch (final ClassNotFoundException | LinkageError ignored) {
> try {
> clazz = Loader.initializeClass(className,
> this.getClass().getClassLoader());
> } catch (final ClassNotFoundException | LinkageError ignore) {
> return null;
> }
> }
> return clazz;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
