On Monday, September 29, 2014, Remko Popma <[email protected]> wrote:
> It is ok for a subclass or interface impl to throw fewer exceptions than > declared by super/interface. (But not more.) > Actually, I take that back: I'm not sure that Serialization works: Matt's link says it must have that _exact_ signature. The compiler may accept it, but it may not do what we want. > > > Sent from my iPhone > > On 2014/09/29, at 5:20, Ralph Goers <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > > I find that surprising to me as well. I would have thought that would > generate a compiler error. > > Ralph > > > On Sep 28, 2014, at 8:27 AM, Matt Sicker <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > > http://docs.oracle.com/javase/8/docs/api/java/io/Serializable.html > > Is it ok to not have the exact exception signature then? > > ---------- Forwarded message ---------- > From: <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> > Date: 27 September 2014 07:31 > Subject: git commit: The declared exception ClassNotFoundException is not > actually thrown by the private method readObject(ObjectInputStream) from > type MessageFormatMessage. > To: [email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');> > > > Repository: logging-log4j2 > Updated Branches: > refs/heads/master 12715841a -> 95132eb37 > > > The declared exception ClassNotFoundException is not actually thrown by > the private method readObject(ObjectInputStream) from type > MessageFormatMessage. > > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo > Commit: > http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/95132eb3 > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/95132eb3 > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/95132eb3 > > Branch: refs/heads/master > Commit: 95132eb371e0cf6ed422ee9155ac4a64b2bfdcc5 > Parents: 1271584 > Author: Gary Gregory <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> > Authored: Sat Sep 27 08:31:08 2014 -0400 > Committer: Gary Gregory <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> > Committed: Sat Sep 27 08:31:08 2014 -0400 > > ---------------------------------------------------------------------- > .../org/apache/logging/log4j/message/MessageFormatMessage.java | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/95132eb3/log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java > ---------------------------------------------------------------------- > diff --git > a/log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java > b/log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java > index 45a6b31..705aed9 100644 > --- > a/log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java > +++ > b/log4j-api/src/main/java/org/apache/logging/log4j/message/MessageFormatMessage.java > @@ -144,7 +144,7 @@ public class MessageFormatMessage implements Message { > } > } > > - private void readObject(final ObjectInputStream in) throws > IOException, ClassNotFoundException { > + private void readObject(final ObjectInputStream in) throws > IOException { > parameters = null; > throwable = null; > formattedMessage = in.readUTF(); > > > > > -- > Matt Sicker <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> > > >
