+1 Site looks good. Unable to check much more, sorry. -Remko Sent from my iPhone
> On 2015/02/25, at 6:14, Christian Grobmeier <[email protected]> wrote: > > +1. > > I haven't seen much more than already said. I used the -tar distribution to > build things and run mvn tests. > > java version "1.8.0_31" > > I did not build the site, as it failed with mvn 3.2.5. But this was already > covered by Gary, so I am ignoring. Hope thats ok. > > In addition I did check sigs and md5 sums using this script: > > https://gist.github.com/grobmeier/80a261c99e5996472c98 > (comments welcome) > > Thanks guys! > > Christian > > >> On Mon, Feb 23, 2015, at 20:34, Gary Gregory wrote: >> +1 >> >> Working from the -src zip distribution file (MD5 OK, SHA1 OK, all >> distribution ASCs are OK) with: >> >> Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 >> 05:51:28-0800) >> Maven home: C:\Java\apache-maven-3.0.5 >> Java version: 1.7.0_75, vendor: Oracle Corporation >> Java home: C:\Program Files\Java\jdk1.7.0_75\jre >> Default locale: en_US, platform encoding: Cp1252 >> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >> >> Maven 3.2.3 does not work to build the site due to some plugin compatibility >> issues. >> >> This should be cleaned up but it is not a blocker: >> >> - RAT >> Unapproved licenses: >> >> >> C:/temp/rc/log4j/log4j-distribution/2.2/log4j-distribution-2.2-src/apache-log4j-2.2-src/log4j-api/felix-cache/cache.lock >> All other RAT reports are clean. >> >> - Checkstyle >> Lots of Checkstyle errors (not blockers), including ones like this, which >> would be nice to deal with: >> org/apache/logging/log4j/io/LoggerBufferedInputStream.java >> >> Severity >> Category >> Rule >> Message >> Line >> Error >> header >> Header >> Line does not match expected header line of ' * contributor lic >> - PMD >> >> PMD reports: >> >> Format-string method String.format(String, Object[]) called with format >> string "}%n" wants 0 arguments but is given 1 in >> org.apache.logging.log4j.core.tools.Generate.generateSource(String, List, >> Generate$Type) >> >> for the line: >> >> sb.append(String.format("}%n", "")); >> Which seems harmless but ugly and confusion. >> >> I also fixed a non-blocker PMD issue (Commit comment: "Fix FindBugs: no need >> use a temporary Integer object.") >> Is this due to a typo? "Potentially dangerous use of non-short-circuit logic >> in org.apache.logging.log4j.core.config.AbstractConfiguration.stop()" >> >> - Site >> The site page https://people.apache.org/~rgoers/log4j2/log4j-web/index.html >> contains empty AID and GID coordinates in the POM XML example. Not pretty >> but not a blocker IMO. >> >> This brings up the point that we do not consistently document (or not >> document) this information for each module. >> The link to http://www.eaipatterns.com/WireTap.html on the IO Streams module >> index page was broken when I tried it; YMMV. If it is broken for other >> folks, not pretty but not a blocker. A summary or full write up would be >> nice on our site. >> Gary >> >> On Sun, Feb 22, 2015 at 3:50 PM, Ralph Goers <[email protected]> >> wrote: >> This is a vote to release Log4j 2.2, the next version of the Log4j 2 project. >> >> Please download, test, and cast your votes on the log4j developers list. >> [] +1, release the artifacts >> [] -1, don't release because... >> >> The vote will remain open for 72 hours (or more if required). All votes are >> welcome, but only Logging PMC votes are “officially” counted. As always, at >> least 3 +1 votes are required. >> >> Changes in this version include: >> >> New features: >> o LOG4J2-941: Allow JSON layout to create one compact log record per line. >> Thanks to Konstantinos Liakos. >> o LOG4J2-933: HTML layout should not use attribute minimalization for hr >> noshade. Thanks to ppiman at gmail.com. >> o LOG4J2-895: Specify the SyslogAppender connect timeout value as part of >> the configuration. >> The SyslogAppender takes a new parameter connectTimeoutMillis. >> o LOG4J2-899: Specify the SocketAppender connect timeout value as part of >> the configuration. >> The SyslogAppender takes a new parameter connectTimeoutMillis. >> >> Fixed Bugs: >> o LOG4J2-938: (JMX) To avoid memory leaks when web applications are >> restarted, JMX notifications are sent from >> the caller thread in web applications. For non-web applications >> notifications are sent from a background thread >> as before. Thanks to Mauro Molinari. >> o LOG4J2-957: Missing toUpperCase("Locale.ENGLISH"). Thanks to fatih >> guleryuz. >> o LOG4J2-956: Manual refers to Route "AppenderRef" attribute, should be >> "ref". Thanks to David Kellerman. >> o LOG4J2-944: Log4j Flume appender is not adding millisecond to the event >> headers when the event is logged at 000 milliseconds. Thanks to Vinayaka >> Ramachandra. >> o LOG4J2-924: Log4j 1.2 Bridge doesn't map level ALL correctly in >> Category.getEffectiveLevel(). Thanks to Ryan Rupp. >> o LOG4J2-931: ConsoleAppender is missing @PluginFactory annotation at >> createAppender method. Thanks to Robert Gacki. >> o LOG4J2-919: Logging system fails to initialize if XInclude API is not >> available. Thanks to David Johle. >> o LOG4J2-914: ThrowableProxy.getExtendedStackTraceAsString causes >> NullpointerException. Thanks to Kaj Bjurman. >> o LOG4J2-912: XML configuration does not report full error message for >> XInclude parser configuration problems. >> o LOG4J2-903: ClassLoaderContextSelector uses ClassLoader.toString() as a >> key Thanks to Mauro Molinari. >> o LOG4J2-834: ThrowableProxy throws NoClassDefFoundError. Thanks to Nikita >> Koval, Leonard Broman, Thiago Kronig. >> o LOG4J2-893: NullPointerException on filter when mapping JUL to Log4j2. >> o LOG4J2-892: JUL adapter does not map Log4j'2 FATAL level to a JUL level. >> o LOG4J2-881: AbstractLifecycle should not implement equals() and >> hashCode(). Thanks to Mariano Gonzalez. >> o LOG4J2-897: Javadoc for org.apache.log4j.BasicConfigurator.configure() is >> incorrect. >> o LOG4J2-891: AbstractLifecycle should not implement equals() and >> hashCode(). >> o LOG4J2-946: [docs] Using Log4j 2 in Web Applications: Update example >> (Log4jWebLifeCycle is not visible). Thanks to artemonster. >> >> Changes: >> o LOG4J2-955: Documentation: clarify system properties to control status >> logger, improve troubleshooting FAQ entry. >> o LOG4J2-950: Incorrect attribute name in PropertiesRewritePolicy example. >> Thanks to Joel Edwards. >> o LOG4J2-901: Update docs for SyslogAppender: "No structured id name was >> supplied" Thanks to Tihomir Meščić, Siegfried Greisinger. >> o LOG4J2-958: Update from Jackson 2.5.0 to 2.5.1. >> o LOG4J2-925: Update from Jackson 2.4.4 to 2.5.0. >> o LOG4J2-910: Update Jackson from 2.4.3 to 2.4.4. >> o LOG4J2-881: Update Jackson from 2.4.2 to 2.4.3. >> o LOG4J2-882: Update maven-core from 3.1.0 to 3.2.3. >> o LOG4J2-883: Update tests from org.apache.felix.framework 4.2.1 to 4.4.1. >> o LOG4J2-884: Update org.eclipse.osgi from 3.6.0 to 3.7.1. >> o LOG4J2-900: Update Apache Flume from 1.5.0.1 to 1.5.2. >> Tag: >> https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=tree;hb=3f4831138852200184ee16fe57fe5342c1291c4b >> or >> >> a) for a new copy do "git clone >> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then "git >> checkout tags/log4j-2.2" >> >> b) for an existing working copy to “git pull” and then “git checkout >> tags/log4j-2.2" >> >> >> >> >> >> Web Site: http://people.apache.org/~rgoers/log4j2/ >> >> >> >> Artifacts: >> https://repository.apache.org/content/repositories/orgapachelogging-1012 >> >> >> >> You may download all the artifacts by executing: >> >> >> >> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate >> https://repository.apache.org/content/repositories/orgapachelogging-1012/org/apache/logging/log4j/ >> >> >> Ralph >> >> >> >> >> >> >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second Edition >> JUnit in Action, Second Edition >> Spring Batch in Action >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >
