Yeah, that's a bit too clever and does not give you the option of actually having a Throwable as an "Object" that will be toString()...
Gary On Fri, Feb 27, 2015 at 4:41 PM, Remko Popma <[email protected]> wrote: > Nice catch! I just saw this happen at work, I agree we should do something > about it. > > One solution would be to modify ObjectMessage.getFormattedString(): > If the object is an instance of Throwable then return the Throwable's > stacktrace instead of its toString() result. > > I'm not a big fan of using instanceof, but it gives us a very compact > solution. > > Thoughts? > > Sent from my iPhone > > On 2015/02/28, at 8:33, Gary Gregory <[email protected]> wrote: > > Hi All: > > I was just surprised (in a bad) way that calling: > > logger.trace(Throwable) compiles to the Object version of the API since we > do not have a Throwable API. > > This means I am forced to do: > > logger.trace("Cause:", throwable); > > in order to see the stack trace. > > Thoughts on adding trace(Throwable)? (As well as the other levels) > > Gary > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
