[ 
https://issues.apache.org/jira/browse/LOG4J2-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375234#comment-14375234
 ] 

Gary Gregory edited comment on LOG4J2-982 at 3/23/15 1:53 AM:
--------------------------------------------------------------

I just got failures in the core module with a reconfigure test running a build 
with this patch. It could be a random error. I'll try again. Did you run a 
maven build with 'mvn test' for example?

The patch causes the following unit test failures:

{noformat}
Failed tests:
  TestConfigurator.testReconfiguration:244 Configuration not reset
Expected: is not 
sameInstance(<XmlConfiguration[location=C:\vcs\git\apache\logging\logging-log4j2\log4j-core\target\test-classes\log4j2-config.xml]>)
     but: was 
<XmlConfiguration[location=C:\vcs\git\apache\logging\logging-log4j2\log4j-core\target\test-classes\log4j2-config.xml]>
  FileConfigTest.testReconfiguration:61 Reconfiguration failed expected not same
  LoggerTest.testReconfiguration:212 Reconfiguration failed expected not same   
        
{noformat}


was (Author: garydgregory):
I just got error in the core with a reconfigure test running a build with this 
patch. It could be a random error. I'll try again. Did you run a maven build 
with 'mvn test' for example?

The patch causes the following unit test failures:

{noformat}
Failed tests:
  TestConfigurator.testReconfiguration:244 Configuration not reset
Expected: is not 
sameInstance(<XmlConfiguration[location=C:\vcs\git\apache\logging\logging-log4j2\log4j-core\target\test-classes\log4j2-config.xml]>)
     but: was 
<XmlConfiguration[location=C:\vcs\git\apache\logging\logging-log4j2\log4j-core\target\test-classes\log4j2-config.xml]>
  FileConfigTest.testReconfiguration:61 Reconfiguration failed expected not same
  LoggerTest.testReconfiguration:212 Reconfiguration failed expected not same   
        
{noformat}

> Use System.nanoTime() to measure time intervals
> -----------------------------------------------
>
>                 Key: LOG4J2-982
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-982
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core, Flume Appender
>            Reporter: Mikhail Mazurskiy
>            Priority: Minor
>         Attachments: LOG4J2-982.patch
>
>
> Unlike {{System.currentTimeMillis()}}, which can jump/slew forward and 
> backwards, {{System.nanoTime()}} is a monotonic clock (at least it should be) 
> and hence it should be used to measure time intervals (timeouts/delays/etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to