[ 
https://issues.apache.org/jira/browse/LOG4J2-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506473#comment-14506473
 ] 

ASF GitHub Bot commented on LOG4J2-997:
---------------------------------------

GitHub user mayt opened a pull request:

    https://github.com/apache/logging-log4j2/pull/11

    LOG4J2-997: Fix addFilter() and removeFilter() in AbstractFilterable.class

    Accessing the filter after addition/removal should follow the following 
logic:
    * If there are no Filter, return null
    * If there is one Filter, return the Filter
    * If there are more than one Filters, return a CompositeFilter of the 
Filters

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayt/logging-log4j2 LOG4J2-997

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 01dcbe7fbde3e1e69881c07123c1f151a9401346
Author: Maytee Chinavanichkit <mchina...@quantcast.com>
Date:   2015-04-10T06:12:02Z

    LOG4J2-997: Fix addFilter() and removeFilter() in AbstractFilterable.class

----


> removeFilter() in AbstractFilterable does not remove filter
> -----------------------------------------------------------
>
>                 Key: LOG4J2-997
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-997
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.2
>            Reporter: Maytee Chinavanichkit
>
> Add two filters to a class that implements AbstractFilterable. Try to remove 
> one of the two filters; nothing is removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to