I committed another hacky workaround. Let's see what happens. See my //
TODO in the code -> there must be a better way...

Gary

On Sun, May 3, 2015 at 1:34 PM, Ralph Goers <ralph.go...@dslextreme.com>
wrote:

> It seems to me that the problem is that File().toURI() is being called.
> This is encoding the string - but it is leaving the ‘+’ characters alone
> instead of converting them to %2B. So when the URI is decoded the “+” is
> converted to a space.
>
> Ralph
>
> On May 3, 2015, at 12:43 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Ah cool! It's great you have a locally reproducible bug now :-)
>
> G
>
> On Sun, May 3, 2015 at 12:31 PM, Ralph Goers <ralph.go...@dslextreme.com>
> wrote:
>
>> I was able to reproduce the problem on OS/X.  Simply rename the directory
>> the log4j project resides in to contain a space such as “My Master”.
>>
>> Running org.apache.logging.log4j.core.util.FileUtilsTest
>> Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.02 sec
>> <<< FAILURE! - in org.apache.logging.log4j.core.util.FileUtilsTest
>> testFileFromUriWithPlusCharactersInName(org.apache.logging.log4j.core.util.FileUtilsTest)
>> Time elapsed: 0.006 sec  <<< FAILURE!
>> org.junit.ComparisonFailure:
>> expected:<log4j[+config+with+plus+]characters.xml> but was:<log4j[ config
>> with plus ]characters.xml>
>> at org.junit.Assert.assertEquals(Assert.java:115)
>> at org.junit.Assert.assertEquals(Assert.java:144)
>> at
>> org.apache.logging.log4j.core.util.FileUtilsTest.testFileFromUriWithPlusCharactersInName(FileUtilsTest.java:44)
>>
>>
>> Results :
>>
>> Failed tests:
>>   FileUtilsTest.testFileFromUriWithPlusCharactersInName:44
>> expected:<log4j[+config+with+plus+]characters.xml> but was:<log4j[ config
>> with plus ]characters.xml>
>>
>>
>>
>>
>> On May 3, 2015, at 10:56 AM, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>> I've added more asserts
>> to 
>> org.apache.logging.log4j.core.util.FileUtilsTest.testFileExistsWithPlusCharactersInName().
>>
>> It all works for me on Oracle Java 6 and 7 (all 64 bit) on Windows.
>>
>> Must some Linux vs Windows thing?
>>
>> Gary
>>
>> On Sun, May 3, 2015 at 1:59 AM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> I added this test to help
>>> debug: 
>>> org.apache.logging.log4j.core.util.FileUtilsTest.testFileExistsWithPlusCharactersInName()
>>>
>>> Going to bed now... 2am :-( Sorry I cannot help more ATM.
>>>
>>> Gary
>>>
>>> On Sun, May 3, 2015 at 12:13 AM, Ralph Goers <ralph.go...@dslextreme.com
>>> > wrote:
>>>
>>>> I modified the configuration to use Java 7. These are the results.
>>>>
>>>> Ralph
>>>>
>>>> > On May 3, 2015, at 12:11 AM, Apache Jenkins Server <
>>>> jenk...@builds.apache.org> wrote:
>>>> >
>>>> > See <https://builds.apache.org/job/Log4j%202.x/changes>
>>>> >
>>>> >
>>>> > ---------------------------------------------------------------------
>>>> > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
>>>> > For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>>>> >
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
>>>> For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Reply via email to