FYI: I started reviewing but I have to take a break and get back in it later tonight.
Gary On Wed, Aug 26, 2015 at 1:49 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote: > I’ll try to take a look tonight. > > Do you have feedback on the Assembler work? > > Ralph > > On Aug 26, 2015, at 1:28 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > Hi All, > > To make it easier to implement a LevelRangeFilter (patch with test here: > https://issues.apache.org/jira/browse/LOG4J2-1106) I'd like to add a new > method to the public API: org.apache.logging.log4j.Level.isInRange(Level, > Level) > > This seems like right place which since we already have: > > - org.apache.logging.log4j.Level.isLessSpecificThan(Level) > - org.apache.logging.log4j.Level.isMoreSpecificThan(Level) > > Please see https://issues.apache.org/jira/browse/LOG4J2-1105 for the > patch (with tests). > > New API: https://issues.apache.org/jira/browse/LOG4J2-1105 > New Filter: https://issues.apache.org/jira/browse/LOG4J2-1106 > > OK, not OK? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory