After this change I am not getting the following compile failure [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project log4j-core: Compilation failure: Compilation failure: [ERROR] required: Class<T> [ERROR] found: Class<BuiltConfiguration> [ERROR] where T is a type-variable: [ERROR] T extends BuiltConfiguration declared in class DefaultConfigurationBuilder [ERROR] /Users/rgoers/projects/apache/logging/log4j/log4j2/logging-log4j2/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java:[202,42] error: cannot infer type arguments for DefaultComponentBuilder<>; [ERROR] reason: inferred type does not conform to declared bound(s) [ERROR] inferred: ComponentBuilder<CAP#1> [ERROR] bound(s): ComponentBuilder<ComponentBuilder<CAP#1>> [ERROR] where CAP#1 is a fresh type-variable: [ERROR] CAP#1 extends ComponentBuilder<CAP#1> from capture of ? [ERROR] /Users/rgoers/projects/apache/logging/log4j/log4j2/logging-log4j2/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java:[209,42] error: cannot infer type arguments for DefaultComponentBuilder<>;
> On Aug 31, 2015, at 11:52 AM, [email protected] wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/LOG4J2-952 c73ef9f4c -> 310d65dd3 > > > Fix Generics compiler warnings. > > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo > Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/310d65dd > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/310d65dd > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/310d65dd > > Branch: refs/heads/LOG4J2-952 > Commit: 310d65dd369a6f7513d51dd6a76713bcb0a53d12 > Parents: c73ef9f > Author: ggregory <[email protected]> > Authored: Mon Aug 31 11:52:49 2015 -0700 > Committer: ggregory <[email protected]> > Committed: Mon Aug 31 11:52:49 2015 -0700 > > ---------------------------------------------------------------------- > .../core/config/builder/impl/DefaultConfigurationBuilder.java | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/310d65dd/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java > ---------------------------------------------------------------------- > diff --git > a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java > > b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java > index b505de6..95d5281 100644 > --- > a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java > +++ > b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java > @@ -211,13 +211,13 @@ public class DefaultConfigurationBuilder<T extends > AssembledConfiguration> imple > @Override > @SuppressWarnings({"unchecked", "rawtypes"}) > public ComponentBuilder<ComponentBuilder> newComponent(String name, > String type) { > - return new DefaultComponentBuilder(this, name, type); > + return new DefaultComponentBuilder<>(this, name, type); > } > > @Override > @SuppressWarnings({"unchecked", "rawtypes"}) > public ComponentBuilder<ComponentBuilder> newComponent(String name, > String type, String value) { > - return new DefaultComponentBuilder(this, name, type, value); > + return new DefaultComponentBuilder<>(this, name, type, value); > } > > @Override > >
