[ 
https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728496#comment-14728496
 ] 

Ralph Goers edited comment on LOG4J2-435 at 9/3/15 5:02 AM:
------------------------------------------------------------

I like this proposal very much! 

It does make me wonder though whether it really needs to be a sub-component of 
an Appender. I've been thinking about adding a generic worker thread (i.e - an 
Executor) that can trigger the file rollover, or other things that need to be 
done periodically. If we have such a thing then it might make sense to have a 
<Schedule> component in the configuration and add the DeletePolicy (or 
DeleteTrigger or whatever) configured there as a scheduled task.

Also, with a name like DeletePolicy I would have expected it to be within the 
Policies element?


was (Author: ralph.go...@dslextreme.com):
I like this proposal very much! 

It does make me wonder though whether it really needs to be a sub-component of 
an Appender. I've been thinking about adding a generic worker thread (i.e - an 
Executor) that can trigger the file rollover, or other things that need to be 
done periodically. If we have such a thing then it might make sense to have a 
<Schedule> component in the configuration and add the DeletePolicy (or 
DeleteTrigger or whatever) configured there as a scheduled task.

> Support limiting number of log files based on date pattern
> ----------------------------------------------------------
>
>                 Key: LOG4J2-435
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-435
>             Project: Log4j 2
>          Issue Type: Improvement
>            Reporter: Arkin Yetis
>            Assignee: Ralph Goers
>              Labels: Rollover
>         Attachments: LimitingRolloverStrategy.java, SizeParser.java
>
>
> DefaultRolloverStrategy max attribute only applies if you have a %i in the 
> file pattern. This request is to enhance DefaultRolloverStrategy or another 
> appropriate component to allow a max number of files limit to apply across 
> days/months/years when a filePattern includes a date pattern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to