FWIW: I know 120 is used in many Apache projects. At work we use 140 in some projects. I use a laptop standalone and I hook it up to an external monitor as well. I use Eclipse and it's all good for me in both set ups.
Gary On Wed, Sep 9, 2015 at 10:28 PM, Ralph Goers <[email protected]> wrote: > When I am working “normally” my IDE is using a monitor that can handle a > line length much wider than that. But if I only have my laptop screen 120 > characters is a reasonable limit. I think most of the other settings make > sense. Let me know if you think otherwise. > > Ralph > > On Sep 9, 2015, at 10:16 PM, Gary Gregory <[email protected]> wrote: > > I wonder if we should also review the checkstyle to see if they still make > sense WRT line lengths and such. > > Gary > > On Wed, Sep 9, 2015 at 10:05 PM, Ralph Goers <[email protected]> > wrote: > >> I guess I should also note that FastDateParser beats JeroMQAppender. It >> has 233 checkstyle errors. >> >> Ralph >> >> > On Sep 9, 2015, at 10:02 PM, Ralph Goers <[email protected]> >> wrote: >> > >> > I see 118 checkstyle errors in JeroMQAppender. Note that core has 1567 >> errors total, many of which are instance variables or constructors out of >> order, lines longer than 120 characters, lines with trailing spaces. >> > >> > It is interesting that many of the files in >> org/apache/logging/log4j/core/config/plugins do not fail RAT but do fail >> checkstyle saying the license is wrong. >> > >> > Ralph >> > >> >> On Sep 9, 2015, at 4:02 PM, Gary Gregory (JIRA) <[email protected]> >> wrote: >> >> >> >> >> >> [ >> https://issues.apache.org/jira/browse/LOG4J2-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> >> >> Gary Gregory resolved LOG4J2-1113. >> >> ---------------------------------- >> >> Resolution: Fixed >> >> >> >> In Git master. Feel free to review, comment, opine, and so on. >> >> >> >>> New publisher Appender for ZeroMQ (using JeroMQ) >> >>> ------------------------------------------------ >> >>> >> >>> Key: LOG4J2-1113 >> >>> URL: https://issues.apache.org/jira/browse/LOG4J2-1113 >> >>> Project: Log4j 2 >> >>> Issue Type: New Feature >> >>> Environment: Apache Maven 3.3.3 >> (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T04:57:37-07:00) >> >>> Maven home: C:\Java\apache-maven-3.3.3\bin\.. >> >>> Java version: 1.7.0_79, vendor: Oracle Corporation >> >>> Java home: C:\Program Files\Java\jdk1.7.0_79\jre >> >>> Default locale: en_US, platform encoding: Cp1252 >> >>> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >> >>> Reporter: Gary Gregory >> >>> Assignee: Gary Gregory >> >>> Fix For: 2.4 >> >>> >> >>> Attachments: log4j-zeromq.patch >> >>> >> >>> >> >>> Create new publisher Appender for ZeroMQ (using JeroMQ) >> >> >> >> >> >> >> >> -- >> >> This message was sent by Atlassian JIRA >> >> (v6.3.4#6332) >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> >> >> > >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> > >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
