Looking at Log4jLogEvent::hashCode, there are many unnecessary Checkstyle MagicNumber warnings for this. I've tried surrounding the offending lines between //Check:OFF: MagicNumber and // Check:ON: MagicNumber comments, and added a SuppressionCommentFilter to /logging-log4j2/checkstyle.xml but Checkstyle still gives these warnings. I don't know how to fix this... The number of warnings is disheartening... :-(
On Thu, Sep 10, 2015 at 1:55 PM, Ralph Goers <[email protected]> wrote: > I am not sure how to run rat that way effectively. I build the site and > review each project’s rat report. > > Ralph > > On Sep 9, 2015, at 9:52 PM, Gary Gregory <[email protected]> wrote: > > Thank you Ralph. Should we make a build fail if a license header is > missing? I've seen some projects do that... > > Gary > > ---------- Forwarded message ---------- > From: <[email protected]> > Date: Wed, Sep 9, 2015 at 9:48 PM > Subject: logging-log4j2 git commit: Add missing license headers > To: [email protected] > > > Repository: logging-log4j2 > Updated Branches: > refs/heads/master e4b980a43 -> 56ccdc586 > > > Add missing license headers > > > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo > Commit: > http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/56ccdc58 > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/56ccdc58 > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/56ccdc58 > > Branch: refs/heads/master > Commit: 56ccdc586139a62bb9bfa73e9b37501048e49650 > Parents: e4b980a > Author: Ralph Goers <[email protected]> > Authored: Wed Sep 9 21:48:11 2015 -0700 > Committer: Ralph Goers <[email protected]> > Committed: Wed Sep 9 21:48:11 2015 -0700 > > ---------------------------------------------------------------------- > .../log4j/core/layout/AbstractCsvLayout.java | 16 ++++++++++++++++ > .../log4j/core/layout/CsvLogEventLayout.java | 16 ++++++++++++++++ > .../log4j/core/layout/CsvParameterLayout.java | 16 ++++++++++++++++ > 3 files changed, 48 insertions(+) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/56ccdc58/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractCsvLayout.java > ---------------------------------------------------------------------- > diff --git > a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractCsvLayout.java > b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractCsvLayout.java > index 6c650d6..2e98a65 100644 > --- > a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractCsvLayout.java > +++ > b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractCsvLayout.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.core.layout; > > import java.nio.charset.Charset; > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/56ccdc58/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvLogEventLayout.java > ---------------------------------------------------------------------- > diff --git > a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvLogEventLayout.java > b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvLogEventLayout.java > index 4eb70eb..25f2fa2 100644 > --- > a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvLogEventLayout.java > +++ > b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvLogEventLayout.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.core.layout; > > import java.io.IOException; > > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/56ccdc58/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvParameterLayout.java > ---------------------------------------------------------------------- > diff --git > a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvParameterLayout.java > b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvParameterLayout.java > index 338049b..69c194b 100644 > --- > a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvParameterLayout.java > +++ > b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/CsvParameterLayout.java > @@ -1,3 +1,19 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one or more > + * contributor license agreements. See the NOTICE file distributed with > + * this work for additional information regarding copyright ownership. > + * The ASF licenses this file to You under the Apache license, Version 2.0 > + * (the "License"); you may not use this file except in compliance with > + * the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > + * See the license for the specific language governing permissions and > + * limitations under the license. > + */ > package org.apache.logging.log4j.core.layout; > > import java.io.IOException; > > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > >
