[ 
https://issues.apache.org/jira/browse/LOG4J2-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933329#comment-14933329
 ] 

Remko Popma commented on LOG4J2-1135:
-------------------------------------

It looks like one line of code got deleted while adding support for other 
compression types:
{code}
if (renameTo.endsWith(EXT_GZIP)) {
    renameTo = renameTo.substring(0, renameTo.length() - EXT_GZIP.length()); // 
THIS LINE WAS ACCIDENTALLY DELETED
    compressAction = new GzCompressAction(new File(renameTo), new 
File(compressedName), true);
} else if (renameTo.endsWith(EXT_ZIP)) {
...
{code}


> Rollover renames to .zip file without compressing
> -------------------------------------------------
>
>                 Key: LOG4J2-1135
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1135
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.4
>            Reporter: Remko Popma
>             Fix For: 2.4.1
>
>
> 林柏川 (Po-Chuan Lin) reported on the log4j-user mailing list that since 2.4 
> compression on rollover is broken.
> I see the following output from the status logger:
> {noformat}
> 2015-09-26 17:43:44,004 main DEBUG RollingFileManager executing synchronous 
> FileRenameAction[logs\test531.log to 
> logs\test531\201509261743\TEST-201509261743-1.log.gz, renameEmptyFiles=false]
> 2015-09-26 17:43:44,004 main DEBUG RollingFileManager executing async 
> GzCompressAction[logs\test531\201509261743\TEST-201509261743-1.log to 
> logs\test531\201509261743\TEST-201509261743-1.log.gz, deleteSource=true]
> {noformat}
> It looks like the file is first renamed to the eventual target file name 
> (with the .zip or .gz etc extension) but not compressed yet. After this the 
> asynchronous compress action tries to rename the moved log file but since the 
> file was renamed to the wrong name it cannot find it and therefore it is not 
> compressed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to